Summary: | REGRESION (r71418): Can't compare new Windows pixel results to existing Windows or Mac results | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Adam Roben (:aroben) <aroben> | ||||
Component: | Tools / Tests | Assignee: | Adam Roben (:aroben) <aroben> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | ||||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | PC | ||||||
OS: | Windows 7 | ||||||
Attachments: |
|
Description
Adam Roben (:aroben)
2010-11-08 06:10:08 PST
Created attachment 73235 [details]
Patch
Comment on attachment 73235 [details]
Patch
Looks like this can be landed, no?
It turns out this isn't needed. The pixel results I was working with only contained alpha due to bugs. No Windows pixel results should contain alpha, so this shouldn't be an issue. But by specifying kCGImageAlphaPremultipliedFirst, rather than throwing away the alpha, we can discover bugs that cause alpha to be written into the image. (In reply to comment #3) > It turns out this isn't needed. The pixel results I was working with only contained alpha due to bugs. No Windows pixel results should contain alpha, so this shouldn't be an issue. But by specifying kCGImageAlphaPremultipliedFirst, rather than throwing away the alpha, we can discover bugs that cause alpha to be written into the image. Wow, this comment is very confused! This patch was needed. It was landed in r71516. |