Bug 49172

Summary: REGRESION (r71418): Can't compare new Windows pixel results to existing Windows or Mac results
Product: WebKit Reporter: Adam Roben (:aroben) <aroben>
Component: Tools / TestsAssignee: Adam Roben (:aroben) <aroben>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Windows 7   
Attachments:
Description Flags
Patch koivisto: review+

Description Adam Roben (:aroben) 2010-11-08 06:10:08 PST 
REGRESION (r71418): Can't compare new Windows pixel results to existing Windows or Mac results
Comment 1 Adam Roben (:aroben) 2010-11-08 06:11:00 PST 
Created attachment 73235 [details]
Patch
Comment 2 Eric Seidel (no email) 2010-12-14 01:45:25 PST 
Comment on attachment 73235 [details]
Patch

Looks like this can be landed, no?
Comment 3 Adam Roben (:aroben) 2010-12-14 07:44:24 PST 
It turns out this isn't needed. The pixel results I was working with only contained alpha due to bugs. No Windows pixel results should contain alpha, so this shouldn't be an issue. But by specifying kCGImageAlphaPremultipliedFirst, rather than throwing away the alpha, we can discover bugs that cause alpha to be written into the image.
Comment 4 Adam Roben (:aroben) 2011-05-05 12:56:18 PDT 
(In reply to comment #3)
> It turns out this isn't needed. The pixel results I was working with only contained alpha due to bugs. No Windows pixel results should contain alpha, so this shouldn't be an issue. But by specifying kCGImageAlphaPremultipliedFirst, rather than throwing away the alpha, we can discover bugs that cause alpha to be written into the image.

Wow, this comment is very confused!

This patch was needed. It was landed in r71516.