| Summary: | Move Cache.* into loader/cache in as a start to cleaning up loader/ | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Eric Seidel (no email) <eric> | ||||||||||
| Component: | New Bugs | Assignee: | Eric Seidel (no email) <eric> | ||||||||||
| Status: | RESOLVED FIXED | ||||||||||||
| Severity: | Normal | CC: | abarth, ap, darin, dbates, dglazkov, fishd, kling, mitz, steveblock, tkent, webkit-ews, xan.lopez, zimmermann | ||||||||||
| Priority: | P2 | ||||||||||||
| Version: | 528+ (Nightly build) | ||||||||||||
| Hardware: | Other | ||||||||||||
| OS: | OS X 10.5 | ||||||||||||
| Bug Depends on: | |||||||||||||
| Bug Blocks: | 49156 | ||||||||||||
| Attachments: |
|
||||||||||||
|
Description
Eric Seidel (no email)
2010-11-07 19:33:28 PST
Created attachment 73203 [details]
Patch
Comment on attachment 73203 [details]
Patch
This isn't going to compile, but yeah, this is what we want.
Attachment 73203 [details] did not build on mac: Build output: http://queues.webkit.org/results/5558013 Comment on attachment 73203 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=73203&action=review > WebCore/WebCore.pro:1034 > - loader/Cache.cpp \ > + loader/cache/Cache.cpp \ You should do the same for loader/Cache.h in this file. Attachment 73203 [details] did not build on qt: Build output: http://queues.webkit.org/results/5516020 Created attachment 73204 [details]
Patch
It built on mac for me, not sure why the bot failed. It built on mac for me, not sure why the bot failed. It looks like the file moves are missing from the patch. I suspect Abarth's webkit-patch chagned_files optimization broke file moves. Created attachment 73205 [details]
manually created patch file
it appears git diff does not include moved files?! Attachment 73204 [details] did not build on mac: Build output: http://queues.webkit.org/results/5532024 Created attachment 73206 [details]
created from an svn checkout
Attachment 73204 [details] did not build on qt: Build output: http://queues.webkit.org/results/5533023 Attachment 73203 [details] did not build on chromium: Build output: http://queues.webkit.org/results/5494017 Committed r71492: <http://trac.webkit.org/changeset/71492> Attachment 73205 [details] did not build on mac: Build output: http://queues.webkit.org/results/5553023 Eric, why is this bug with a patch pending review in RESOLVED/FIXED state? Probably because webkit-patch land doesn't clear r? I don't use webkit-patch land much, maybe clearing of r? broke (or never was?) Maybe because it only clears r+ ? The biggest problem with the Cache class right now is that it’s not just a cache. Moving it into a directory named cache makes that problem worse. (In reply to comment #21) > The biggest problem with the Cache class right now is that it’s not just a cache. Moving it into a directory named cache makes that problem worse. What else does it do besides being a cache? It's involved in the loading process too, but I was planning to move that logic out into a separate class in the interests of making the main document cachable in the memory cache. |