Bug 49138

Summary: [Qt] Path::addArc() does not set right angle direction on full arcs
Product: WebKit Reporter: Helder Correia <helder>
Component: CanvasAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, kling, mdelaney7
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Mac (Intel)   
OS: OS X 10.6   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch none

Helder Correia
Reported 2010-11-07 01:12:05 PST
The test page http://www.html5.jp/test/fillStyle_winding_number_rule2.html is correctly rendered in all browsers except QtTestBrowser. A set of green thick circumferences with the same center and different radius is expected, but a green canvas is obtained instead.
Attachments
Patch (1.77 KB, patch)
2010-11-07 01:21 PST, Helder Correia 		no flags
DetailsFormatted DiffDiff
Patch (43.80 KB, patch)
2010-11-08 13:15 PST, Helder Correia 		no flags
DetailsFormatted DiffDiff
Patch (7.39 KB, patch)
2010-11-10 18:54 PST, Helder Correia 		no flags
DetailsFormatted DiffDiff
Patch (5.68 KB, patch)
2010-11-11 20:43 PST, Helder Correia 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Helder Correia
Comment 1 2010-11-07 01:21:20 PST
Created attachment 73191 [details] Patch
Andreas Kling
Comment 2 2010-11-07 02:44:56 PST
Comment on attachment 73191 [details] Patch Needs a layout test.
Andreas Kling
Comment 3 2010-11-07 05:45:11 PST
(In reply to comment #0) > The test page http://www.html5.jp/test/fillStyle_winding_number_rule2.html is correctly rendered in all browsers except QtTestBrowser. Renders as a filled green rectangle in Chromium here, BTW.
Helder Correia
Comment 4 2010-11-08 13:15:59 PST
Created attachment 73273 [details] Patch
Andreas Kling
Comment 5 2010-11-09 00:56:45 PST
Comment on attachment 73273 [details] Patch This should be tested with a dumpAsText test so not just QtWebKit is covered, it should be easy to create one using canvas's getImageData().
Helder Correia
Comment 6 2010-11-10 18:54:43 PST
Created attachment 73567 [details] Patch
Andreas Kling
Comment 7 2010-11-11 03:09:19 PST
Comment on attachment 73567 [details] Patch Better but not quite there yet. Please put the test logic in the script-tests/ subdirectory. Then use make-script-test-wrappers to generate the boilerplate HTML for the test.
Helder Correia
Comment 8 2010-11-11 20:43:31 PST
Created attachment 73697 [details] Patch
Andreas Kling
Comment 9 2010-11-12 04:14:04 PST
Comment on attachment 73697 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=73697&action=review Excellent, r=me with one comment: > LayoutTests/ChangeLog:11 > + * fast/canvas/canvas-arc-360-winding.html: Added. This test will fail on Chromium, so you should at least add it to their skip list.
WebKit Commit Bot
Comment 10 2010-11-12 12:23:44 PST
Comment on attachment 73697 [details] Patch Clearing flags on attachment: 73697 Committed r71936: <http://trac.webkit.org/changeset/71936>
WebKit Commit Bot
Comment 11 2010-11-12 12:23:50 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.