Bug 49099

Summary: Android's navigator.language hardcoded to "en"
Product: WebKit Reporter: jreck
Component: WebCore Misc.Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, steveblock
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Android   
OS: Android   
Attachments:
Description Flags
Changes Android's WebCore::platformDefaultLanguage() to get the correct value from PlatformBridge none

jreck
Reported 2010-11-05 14:58:47 PDT
from: http://code.google.com/p/android/issues/detail?id=4641 Using navigator.language reports always "en" in androids browser where as my system language is de-at and the browser UI-Language is german as well. Looking at the attributes of the navigator object I see: navigator.language: en navigator.userAgent: Mozilla/5.0(Linux;U;Android 1.5;de-at;T-Mobile_G2_Touch Build/CPUCAKE) AppleWebKit/528.5+ ... navigator.appVersion: 5.0 (Linux;U;Android 1.5; de-at; ...) I know that navigator.language does not reflect the OS-Language but because my browser interacts with me in german I would have expected navigator.language to be "de"
Attachments
Changes Android's WebCore::platformDefaultLanguage() to get the correct value from PlatformBridge (4.86 KB, patch)
2010-11-05 15:03 PDT, jreck 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
jreck
Comment 1 2010-11-05 15:03:53 PDT
Created attachment 73125 [details] Changes Android's WebCore::platformDefaultLanguage() to get the correct value from PlatformBridge
Alexey Proskuryakov
Comment 2 2010-11-05 22:46:41 PDT
Looks fine, assuming it's the normal design pattern for Android to call PlatformBridge from WebCore/platform/android files (which seems weird).
Steve Block
Comment 3 2010-11-07 15:21:49 PST
Comment on attachment 73125 [details] Changes Android's WebCore::platformDefaultLanguage() to get the correct value from PlatformBridge Yes, this is a standard pattern for Android. Chromium uses a similar approach too.
WebKit Commit Bot
Comment 4 2010-11-07 15:38:32 PST
Comment on attachment 73125 [details] Changes Android's WebCore::platformDefaultLanguage() to get the correct value from PlatformBridge Clearing flags on attachment: 73125 Committed r71484: <http://trac.webkit.org/changeset/71484>
WebKit Commit Bot
Comment 5 2010-11-07 15:38:38 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.