Bug 49083

Summary: Clean up imports for webkit-patch.
Product: WebKit Reporter: James Kozianski <koz>
Component: New BugsAssignee: James Kozianski <koz>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, commit-queue, eric, noel.gordon, ojan
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch
eric: review-
Patch
none
Patch
none
Patch
none
Patch none

Description James Kozianski 2010-11-05 11:47:21 PDT 
Clean up imports for webkit-patch.
Comment 1 James Kozianski 2010-11-05 12:15:29 PDT 
Created attachment 73099 [details]
Patch
Comment 2 Ojan Vafai 2010-11-05 13:29:02 PDT 
Comment on attachment 73099 [details]
Patch

Good clean up. Please sort the commands (as per unix sort command).
Comment 3 James Kozianski 2010-11-05 13:50:07 PDT 
Created attachment 73112 [details]
Patch
Comment 4 Ojan Vafai 2010-11-05 14:18:57 PDT 
Comment on attachment 73112 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=73112&action=review

> WebKitTools/Scripts/webkitpy/tool/main.py:46
> +from optparse import make_option
> +from webkitpy.common.net.statusserver import StatusServer

Can these not be in sorted order? I realize the imports surrounding it aren't, but they really should be if they can.
Comment 5 James Kozianski 2010-11-05 14:34:57 PDT 
Created attachment 73120 [details]
Patch
Comment 6 Eric Seidel (no email) 2010-11-05 15:26:35 PDT 
Comment on attachment 73099 [details]
Patch

This was breaking teh win-ews.
Comment 7 Ojan Vafai 2010-11-08 11:27:42 PST 
This patch didn't seem to apply on any of the EWS bots. I assume it won't on the commit-queue either. Any ideas why?
Comment 8 James Kozianski 2010-11-08 15:31:41 PST 
Created attachment 73294 [details]
Patch
Comment 9 James Kozianski 2010-11-08 15:32:34 PST 
Sorry, my bad - my checkout was out of date.
Comment 10 WebKit Commit Bot 2010-11-08 21:45:51 PST 
Comment on attachment 73294 [details]
Patch

Rejecting patch 73294 from commit-queue.

Failed to run "['./WebKitTools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=abarth-cq-sl', 'apply-attachment', '--force-clean', '--non-interactive', 73294]" exit_code: 1
Traceback (most recent call last):
  File "./WebKitTools/Scripts/webkit-patch", line 70, in <module>
    main()
  File "./WebKitTools/Scripts/webkit-patch", line 63, in main
    from webkitpy.tool.main import WebKitPatch
  File "/Users/abarth/git/webkit-queue/WebKitTools/Scripts/webkitpy/tool/main.py", line 42, in <module>
    from webkitpy.common.net.rietveld import Rietveld
ImportError: No module named rietveld

Full output: http://queues.webkit.org/results/5577007
Comment 11 James Kozianski 2010-11-09 11:45:51 PST 
Created attachment 73395 [details]
Patch
Comment 12 James Kozianski 2010-11-09 11:49:28 PST 
Apologies for the failure - it was running fine on my box because there were still lingering .pyc files for .py files that were removed in prior patches.
Comment 13 Eric Seidel (no email) 2010-11-09 12:05:00 PST 
Comment on attachment 73395 [details]
Patch

Looks fine, assuming it runs.  Last time this patch broke the win-ews :(
Comment 14 WebKit Commit Bot 2010-11-09 12:24:21 PST 
Comment on attachment 73395 [details]
Patch

Clearing flags on attachment: 73395

Committed r71667: <http://trac.webkit.org/changeset/71667>
Comment 15 WebKit Commit Bot 2010-11-09 12:24:27 PST 
All reviewed patches have been landed.  Closing bug.