Bug 49062 – Generate the messages sent to the WebProcessProxy

• Component: WebKit2
• Status: RESOLVED FIXED

[Sam Weinig]

Generate the messages sent to the WebProcessProxy

[Sam Weinig]

Created attachment 73050 [details]
Patch

[Adam Roben (:aroben)]

Comment on attachment 73050 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=73050&action=review

> WebKit2/Scripts/webkit2/messages.py:253
> +        'WebCore::PluginData.h',

The ".h" seems wrong.

> WebKit2/UIProcess/WebProcessProxy.cpp:232
> +void WebProcessProxy::didPerformClientRedirect(uint64_t pageID, const String& sourceURLString, const String& destinationURLString, uint64_t frameID)
> +{
> +    m_context->didPerformClientRedirect(webFrame(frameID), sourceURLString, destinationURLString);
> +}

Will the unused pageID variable cause compiler warnings/errors?

Why are we sending along the pageID if we don't need it?

(These questions apply to a few other functions in this file.)

[Sam Weinig]

(In reply to comment #2)
> (From update of attachment 73050 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=73050&action=review
> 
> > WebKit2/Scripts/webkit2/messages.py:253
> > +        'WebCore::PluginData.h',
> 
> The ".h" seems wrong.

Fixed. This would have broken clang and msvc!

> 
> > WebKit2/UIProcess/WebProcessProxy.cpp:232
> > +void WebProcessProxy::didPerformClientRedirect(uint64_t pageID, const String& sourceURLString, const String& destinationURLString, uint64_t frameID)
> > +{
> > +    m_context->didPerformClientRedirect(webFrame(frameID), sourceURLString, destinationURLString);
> > +}
> 
> Will the unused pageID variable cause compiler warnings/errors?
> 
> Why are we sending along the pageID if we don't need it?
> 
> (These questions apply to a few other functions in this file.)

Not sure, but it isn't new. I will talk to Anders/Brady when I get a chance.

[Sam Weinig]

Landed in http://trac.webkit.org/changeset/71423.