Bug 49051

Summary:

build-webkit spams system.log by repeatedly checking for PBXProductDirectory in com.apple.Xcode

Product:

WebKit

Reporter:

Eric Seidel (no email) <eric>

Component:

Tools / Tests

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, commit-queue, dpranke, eric, kbr, kling, mrobinson, ojan

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

OS X 10.5

Attachments:

Description	Flags
Patch	none

Eric Seidel (no email)

Reported 2010-11-04 20:51:46 PDT

build-webkit spams system.log by repeatedly checking for PBXProductDirectory in com.apple.Xcode When it's missing, you get this spam: Nov 3 00:32:55 eseidel defaults[38804]: \nThe domain/default pair of (com.apple.Xcode, PBXProductDirectory) does not exist Nov 3 00:32:55 eseidel defaults[38814]: \nThe domain/default pair of (com.apple.Xcode, PBXProductDirectory) does not exist Nov 3 00:32:55 eseidel defaults[38824]: \nThe domain/default pair of (com.apple.Xcode, PBXProductDirectory) does not exist Nov 3 00:32:56 eseidel defaults[38834]: \nThe domain/default pair of (com.apple.Xcode, PBXProductDirectory) does not exist Nov 3 00:32:56 eseidel defaults[38844]: \nThe domain/default pair of (com.apple.Xcode, PBXProductDirectory) does not exist Nov 3 00:32:56 eseidel defaults[38854]: \nThe domain/default pair of (com.apple.Xcode, PBXProductDirectory) does not exist I have thousands of these in my system.log.

Attachments
Patch (4.15 KB, patch) 2010-11-04 22:30 PDT, Eric Seidel (no email)	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Eric Seidel (no email)

Comment 1 2010-11-04 20:54:26 PDT

I've also filed radar 8634566 about defaults logging to system.log in the first place.

Eric Seidel (no email)

Comment 2 2010-11-04 20:59:10 PDT

Actually, it's probably coming from the python code using webkit-build-directory.

Eric Seidel (no email)

Comment 3 2010-11-04 22:30:10 PDT

Created attachment 73036 [details] Patch

Eric Seidel (no email)

Comment 4 2010-11-04 22:35:12 PDT

This will conflict with one of dpranke's pending patches, so I should land this by hand. (Unless he'd like me to go first in which case he should feel free to set cq+ or cq? on it.)

Eric Seidel (no email)

Comment 5 2010-11-05 01:54:17 PDT

Comment on attachment 73036 [details] Patch Eh. On second thought, it's actually easier to just land this and let Dirk merge in the morning.

WebKit Commit Bot

Comment 6 2010-11-05 02:14:33 PDT

Comment on attachment 73036 [details] Patch Clearing flags on attachment: 73036 Committed r71398: <http://trac.webkit.org/changeset/71398>

WebKit Commit Bot

Comment 7 2010-11-05 02:14:39 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.