Bug 49034

Summary: Plugins draw unclipped in pixel tests
Product: WebKit Reporter: Adam Roben (:aroben) <aroben>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED WONTFIX    
Severity: Normal CC: ahmad.saleem792, andersca, ap, jhoneycutt
Priority: P2 Keywords: InRadar, PlatformOnly
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Windows XP   
Attachments:
Description Flags
test case none

Adam Roben (:aroben)
Reported 2010-11-04 15:45:25 PDT
To reproduce: 1. Download the attached file to LayoutTests/platform/win/plugins 2. run-webkit-tests -p --reset-results plaform/win/plugins/overflow-clip.html 3. Open LayoutTests/platform/win/platform/win/plugins/overflow-clip-expected.png The (quite colorful) plugin is overlapping the text. It should be clipped to a 50x50 square. The clipping works fine in the browser, and in DRT (if you modify DRT to put its window on screen). But when creating the image for the pixel dump via WM_PRINT, the plugin's clip seems to be ignored by Windows. It would be good to have a way to make pixel tests of clipped plugins.
Attachments
test case (629 bytes, text/html)
2010-11-04 16:06 PDT, Adam Roben (:aroben) 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Adam Roben (:aroben)
Comment 1 2010-11-04 16:06:33 PDT
Created attachment 72999 [details] test case
Adam Roben (:aroben)
Comment 2 2010-11-04 16:06:59 PDT
<rdar://problem/8633402>
Adam Roben (:aroben)
Comment 3 2011-05-06 15:46:23 PDT
We clip plugins using ::SetWindowRgn. I guess WM_PRINT doesn't pay attention to the window's window region. :-\
Adam Roben (:aroben)
Comment 4 2011-05-06 15:51:41 PDT
This affects how plugins appear in Safari's dragged-out tab mini-windows, too.
Ahmad Saleem
Comment 5 2022-10-23 12:19:20 PDT
Webkit / Safari does not support plugins anymore so I think we can close this. Marking this as "RESOLVED WONTFIX". Please reopen, if it is still needed. Thanks!
Note You need to log in before you can comment on or make changes to this bug.