Bug 49030

Summary:

check-webkit-style is ignorant of TestNetscapePlugIn's coding conventions

Product:

WebKit

Reporter:

Adam Roben (:aroben) <aroben>

Component:

Tools / Tests

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Teach check-webkit-style about TestNetscapePlugIn	sullivan: review+

Description Adam Roben (:aroben) 2010-11-04 15:02:09 PDT

check-webkit-style is ignorant of TestNetscapePlugIn's coding conventions. See, e.g.., bug 49028 comment 2. We should teach it!

Comment 1 Adam Roben (:aroben) 2010-11-04 15:13:00 PDT

Created attachment 72988 [details]
Teach check-webkit-style about TestNetscapePlugIn

Comment 2 WebKit Review Bot 2010-11-04 15:16:01 PDT

Attachment 72988 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style', '--diff-files', u'WebKitTools/ChangeLog', u'WebKitTools/Scripts/webkitpy/style/checker.py']" exit_code: 1
WebKitTools/Scripts/webkitpy/style/checker.py:119:  at least two spaces before inline comment  [pep8/E261] [5]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 3 Adam Roben (:aroben) 2010-11-04 15:16:45 PDT

(In reply to comment #2)
> Attachment 72988 [details] did not pass style-queue:
> 
> Failed to run "['WebKitTools/Scripts/check-webkit-style', '--diff-files', u'WebKitTools/ChangeLog', u'WebKitTools/Scripts/webkitpy/style/checker.py']" exit_code: 1
> WebKitTools/Scripts/webkitpy/style/checker.py:119:  at least two spaces before inline comment  [pep8/E261] [5]
> Total errors found: 1 in 2 files
> 
> 
> If any of these errors are false positives, please file a bug against check-webkit-style.

How ironic. I was just following the existing style in this function!

Comment 4 Adam Roben (:aroben) 2010-11-05 07:51:10 PDT

Committed r71419: <http://trac.webkit.org/changeset/71419>