| Summary: | [Qt] Use custom memory allocator in QtTestBrowser on Symbian | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Dinu Jacob <dinu.jacob> | ||||
| Component: | Tools / Tests | Assignee: | Dinu Jacob <dinu.jacob> | ||||
| Status: | RESOLVED INVALID | ||||||
| Severity: | Normal | CC: | ademar, kbalazs, s.mathur, suresh.voruganti | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | S60 Hardware | ||||||
| OS: | S60 3rd edition | ||||||
| Bug Depends on: | |||||||
| Bug Blocks: | 44691, 47918 | ||||||
| Attachments: |
|
||||||
|
Description
Dinu Jacob
2010-11-04 11:37:25 PDT
This is needed to run JS benchmarks (for example, Dromaeo) on Symbian Created attachment 73101 [details]
Patch
Do we really need to push the allocator into the codebase? Wouldn't it be better to just having the lib in the trunk? Fix required for Qtwebkit 2.1 branch for increasing the stability. (In reply to comment #2) > Created an attachment (id=73101) [details] > Patch Please don't put the allocator source into Webkit.org trunk! Alternatives: - For public buildbots, use Qt 4.7 tip of branch (from Gitorious.org/qt) which already has fast allocator in official Qt-Symbian port (see QT-3967 or http://qt.gitorious.org/qt/qt/trees/4.7/src/corelib/arch/symbian) - For internal buildbots, use 4.7 from QtProd which also has allocator built in (QT-3967, wk44 onwards) I checked with the author of the above Qt integration, and he says that no qmake args are needed to turn on linking with the fast allocator. All you have to do it make sure Qt 4.7.2 or higher is in use and compile your application. So, it seems no Webkit.pro pro/.pri need new flags either. If you have privately verified that QTestBrowser is passing all endurance tests with the fast allocator, then that should be enough to "unblock" 2.1 release readiness. (In reply to comment #5) > (In reply to comment #2) > > Created an attachment (id=73101) [details] [details] > > Patch > > Please don't put the allocator source into Webkit.org trunk! > > Alternatives: > - For public buildbots, use Qt 4.7 tip of branch (from Gitorious.org/qt) which already has fast allocator in official Qt-Symbian port (see QT-3967 or http://qt.gitorious.org/qt/qt/trees/4.7/src/corelib/arch/symbian) > - For internal buildbots, use 4.7 from QtProd which also has allocator built in (QT-3967, wk44 onwards) > > I checked with the author of the above Qt integration, and he says that no qmake args are needed to turn on linking with the fast allocator. All you have to do it make sure Qt 4.7.2 or higher is in use and compile your application. So, it seems no Webkit.pro pro/.pri need new flags either. > > If you have privately verified that QTestBrowser is passing all endurance tests with the fast allocator, then that should be enough to "unblock" 2.1 release readiness. Thanks Siddarth. We didn't get this information when we asked around here and the suggestion was to add the code. I will remove the source code and do a build with the Qt that has the lib. Out of scope for Webkit.org or QtWebkit. See Comment #5. |