Bug 49011

Summary: [GStreamer] take video sink ownership with gst_object API
Product: WebKit Reporter: Philippe Normand <pnormand>
Component: MediaAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, slomo
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
proposed patch
none
proposed patch none

Philippe Normand
Reported 2010-11-04 10:49:43 PDT
We should use gst_object_ref_sink() instead of the g_object one to take ownership of the sink because GstObjects have their own floating reference support, as pointed out by Sebastian
Attachments
proposed patch (1.75 KB, patch)
2010-11-04 10:52 PDT, Philippe Normand 		no flags
DetailsFormatted DiffDiff
proposed patch (19.65 KB, patch)
2010-11-08 02:29 PST, Philippe Normand 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Philippe Normand
Comment 1 2010-11-04 10:52:14 PDT
Created attachment 72963 [details] proposed patch
Philippe Normand
Comment 2 2010-11-08 02:29:23 PST
Created attachment 73227 [details] proposed patch
Philippe Normand
Comment 3 2010-11-08 02:30:17 PST
Comment on attachment 73227 [details] proposed patch wrong bug, sorry
Xan Lopez
Comment 4 2010-11-28 09:33:54 PST
Comment on attachment 72963 [details] proposed patch r=me
WebKit Commit Bot
Comment 5 2010-11-29 06:27:43 PST
The commit-queue encountered the following flaky tests while processing attachment 72963 [details]: fast/profiler/throw-exception-from-eval.html Please file bugs against the tests. These tests were authored by kmccullough@apple.com, oliver@apple.com, and timothy@apple.com. The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 6 2010-11-29 06:29:20 PST
Comment on attachment 72963 [details] proposed patch Clearing flags on attachment: 72963 Committed r72793: <http://trac.webkit.org/changeset/72793>
WebKit Commit Bot
Comment 7 2010-11-29 06:29:25 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.