Bug 49003

Summary:

Request.h getters can be made const

Product:

WebKit

Reporter:

Joseph Pecoraro <joepeck>

Component:

WebCore Misc.

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

OS X 10.5

Attachments:

Description	Flags
[PATCH] Adds const qualifier to getters	none

Joseph Pecoraro

Reported 2010-11-04 09:18:09 PDT

I don't see a reason for them not to be const. http://trac.webkit.org/browser/trunk/WebCore/loader/Request.h Let me know if there is no advantage to this patch overwriting the history.

Attachments
[PATCH] Adds const qualifier to getters (1.82 KB, patch) 2010-11-04 09:21 PDT, Joseph Pecoraro	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Joseph Pecoraro

Comment 1 2010-11-04 09:21:54 PDT

Created attachment 72948 [details] [PATCH] Adds const qualifier to getters

Andreas Kling

Comment 2 2010-11-04 09:26:18 PDT

Comment on attachment 72948 [details] [PATCH] Adds const qualifier to getters r=me

WebKit Commit Bot

Comment 3 2010-11-04 09:45:03 PDT

Comment on attachment 72948 [details] [PATCH] Adds const qualifier to getters Clearing flags on attachment: 72948 Committed r71341: <http://trac.webkit.org/changeset/71341>

WebKit Commit Bot

Comment 4 2010-11-04 09:45:08 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.