Summary: | Delegate scrolling via a separate method | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Kenneth Rohde Christiansen <kenneth> | ||||||
Component: | WebCore Misc. | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | andersca, aroben, hyatt, kling, mitz, webkit-ews | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | PC | ||||||||
OS: | All | ||||||||
Attachments: |
|
Description
Kenneth Rohde Christiansen
2010-11-04 04:12:15 PDT
Created attachment 72926 [details]
Patch
Attachment 72926 [details] did not build on qt: Build output: http://queues.webkit.org/results/5099010 Created attachment 72933 [details]
Patch2
Comment on attachment 72933 [details] Patch2 View in context: https://bugs.webkit.org/attachment.cgi?id=72933&action=review > WebCore/platform/ScrollView.cpp:340 > + IntPoint newScrollPosition = scrollPoint.shrunkTo(maximumScrollPosition()); > + newScrollPosition.clampNegativeToZero(); > + > +#if ENABLE(TILED_BACKING_STORE) > if (delegatesScrolling()) { > - scrollContents(IntSize(scrollPoint.x(), scrollPoint.y())); > + hostWindow()->delegatedScrollRequested(IntSize(scrollPoint.x(), scrollPoint.y())); > return; > } > - > - IntPoint newScrollPosition = scrollPoint.shrunkTo(maximumScrollPosition()); > - newScrollPosition.clampNegativeToZero(); > +#endif Looks like you removed the call to scrollContents entirely, even in the non-tiled case. (In reply to comment #4) > (From update of attachment 72933 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=72933&action=review > Looks like you removed the call to scrollContents entirely, even in the non-tiled case. No, that is called later indirectly bye setting the scrollbars. Comment on attachment 72933 [details] Patch2 View in context: https://bugs.webkit.org/attachment.cgi?id=72933&action=review Looks good. > WebCore/ChangeLog:9 > + scrolling to the view. This is only used in conjunging with tiling, "conjunction" is what you meant to say here I think. Committed r71352: <http://trac.webkit.org/changeset/71352> |