Bug 48969 – Need a way to test in WebKit2 whether a form field contains marked text

• Component: WebKit2
• Status: RESOLVED FIXED

[Enrica Casucci]

This is required to support autofill.

[Enrica Casucci]

Created attachment 72897 [details]
Patch

[Alexey Proskuryakov]

Comment on attachment 72897 [details]
Patch

+    // Need to declare these attribute names because AppKit exports them but does not make them available in API or SPI headers.
+    
+    extern NSString *NSMarkedClauseSegmentAttributeName;

This one is in 10.5 SDK.

+    extern NSString *NSTextInputReplacementRangeAttributeName;

This one is not - please file a bug, and reference it in a comment.

+    BOOL _isSelectionInPasswordField;

Since you added this, you probably already know that there is some advanced trickery going on to make sure that password fields are handled correctly by input methods. This is not relevant to this patch, but I wanted to be sure that you look into that later.


+    Frame* frame = m_page->corePage()->focusController()->focusedOrMainFrame();
+    if (!frame)
+        return;

Why ask for main frame if there is no focused one?

r=me

[Enrica Casucci]

(In reply to comment #2)
> (From update of attachment 72897 [details])
> +    // Need to declare these attribute names because AppKit exports them but does not make them available in API or SPI headers.
> +    
> +    extern NSString *NSMarkedClauseSegmentAttributeName;
> 
> This one is in 10.5 SDK.
> 
> +    extern NSString *NSTextInputReplacementRangeAttributeName;
> 
> This one is not - please file a bug, and reference it in a comment.

Done.

> 
> +    BOOL _isSelectionInPasswordField;
> 
> Since you added this, you probably already know that there is some advanced trickery going on to make sure that password fields are handled correctly by input methods. This is not relevant to this patch, but I wanted to be sure that you look into that later.

Yes! 

> 
> 
> +    Frame* frame = m_page->corePage()->focusController()->focusedOrMainFrame();
> +    if (!frame)
> +        return;
> 
> Why ask for main frame if there is no focused one?

Sorry, just copy/paste mistake.

> 
> r=me

[Enrica Casucci]

Committed revision 71347.