Summary: | CG use of WebKit image decoders crashes on some animated GIFs | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Adam Barth <abarth> | ||||||
Component: | New Bugs | Assignee: | Adam Barth <abarth> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | abarth, eric, webkit.review.bot | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Other | ||||||||
OS: | OS X 10.5 | ||||||||
Attachments: |
|
Description
Adam Barth
2010-11-03 14:39:31 PDT
Created attachment 72873 [details]
Patch
Comment on attachment 72873 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=72873&action=review Please consider making a helper function. > WebCore/platform/image-decoders/cg/ImageDecoderCG.cpp:38 > + m_bytes = m_backingStore ? reinterpret_cast<PixelData*>(CFDataGetMutableBytePtr(m_backingStore.get())) : 0; What about a backingStoreAsBytes() method? Seems this is a lot of code to copy/paste. Comment on attachment 72873 [details]
Patch
Maybe I should call it CFDataGetMutableBytePtr. :)
Created attachment 72876 [details]
Patch for landing
Committed r71277: <http://trac.webkit.org/changeset/71277> http://trac.webkit.org/changeset/71277 might have broken Qt Linux Release The following tests are not passing: svg/in-html/by-reference.html svg/in-html/circle.html svg/overflow/overflow-on-outermost-svg-element-in-xhtml-auto.xhtml svg/overflow/overflow-on-outermost-svg-element-in-xhtml-defaults.xhtml svg/overflow/overflow-on-outermost-svg-element-in-xhtml-hidden.xhtml svg/overflow/overflow-on-outermost-svg-element-in-xhtml-scroll.xhtml svg/overflow/overflow-on-outermost-svg-element-in-xhtml-visible.xhtml svg/text/foreignObject-text-clipping-bug.xml svg/text/selection-background-color.xhtml svg/text/selection-styles.xhtml svg/zoom/page/zoom-coords-viewattr-01-b.svg svg/zoom/page/zoom-hixie-mixed-008.xml svg/zoom/page/zoom-hixie-mixed-009.xml svg/zoom/page/zoom-hixie-rendering-model-004.xhtml svg/zoom/page/zoom-svg-float-border-padding.xml These tests were failing both before and after this patch. They blinked "pass" on the run before this one, so they got blamed on this patch, as far as I can tell. |