| Summary: | run-webkit-tests thinks the web process crashed if WebKitTestRunner fails to reset it to a consistent state | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Adam Roben (:aroben) <aroben> |
| Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> |
| Status: | NEW --- | ||
| Severity: | Normal | CC: | mjs, sam |
| Priority: | P2 | Keywords: | InRadar |
| Version: | 528+ (Nightly build) | ||
| Hardware: | All | ||
| OS: | All | ||
|
Description
Adam Roben (:aroben)
2010-11-03 12:46:43 PDT
Perhaps we should count the failure to reset the web process against whatever the last-run test was, since presumably it is the one that screwed things up so the web process couldn't be reset. (In reply to comment #1) > Perhaps we should count the failure to reset the web process against whatever the last-run test was, since presumably it is the one that screwed things up so the web process couldn't be reset. Yeah, that sounds like the correct solution here, then we want the script to re-run the current test. (In reply to comment #1) > Perhaps we should count the failure to reset the web process against whatever the last-run test was, since presumably it is the one that screwed things up so the web process couldn't be reset. One way to accomplish this would be to reset the web process at the end of each test instead of at the beginning, and to wait to dump the test results until the reset is completed. Then, if the reset fails, we could dump an extra message into the test results to indicate the failure, perhaps followed by dumping some special string that would tell run-webkit-tests to relaunch WTR. |