Bug 48862

Summary:

Windows build is broken due to undefined symbol nullptr

Product:

WebKit

Reporter:

Adam Roben (:aroben) <aroben>

Component:

New Bugs

Assignee:

Adam Roben (:aroben) <aroben>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

andersca, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Other

OS:

OS X 10.5

Attachments:

Description	Flags
Patch	andersca: review+

Description Adam Roben (:aroben) 2010-11-02 12:45:20 PDT

Windows build is broken due to undefined symbol nullptr

Comment 1 Adam Roben (:aroben) 2010-11-02 12:46:07 PDT

Created attachment 72716 [details]
Patch

Comment 2 WebKit Review Bot 2010-11-02 12:50:12 PDT

Attachment 72716 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style', '--diff-files', u'JavaScriptCore/ChangeLog', u'JavaScriptCore/JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def', u'JavaScriptCore/JavaScriptCore.vcproj/WTF/WTF.vcproj', u'JavaScriptCore/wtf/NullPtr.cpp']" exit_code: 1
JavaScriptCore/wtf/NullPtr.cpp:27:  Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
Total errors found: 1 in 4 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 3 Adam Roben (:aroben) 2010-11-02 12:52:54 PDT

Committed r71155: <http://trac.webkit.org/changeset/71155>