Bug 48854

Summary: Web Inspector: Remove obsolete code.
Product: WebKit Reporter: Ilya Tikhonovsky <loislo>
Component: Web Inspector (Deprecated)Assignee: Ilya Tikhonovsky <loislo>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, bweinstein, commit-queue, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
[patch] initial version.
pfeldman: review-
[patch] second iteration none

Ilya Tikhonovsky
Reported 2010-11-02 11:02:46 PDT
It is not required to push onload and DOMContentLoaded events times to the fresh instance of Inspector. Network Panel is showing the markers only after reloading the inspected page.
Attachments
[patch] initial version. (1.35 KB, patch)
2010-11-02 11:04 PDT, Ilya Tikhonovsky 		pfeldman: review-
DetailsFormatted DiffDiff
[patch] second iteration (3.56 KB, patch)
2010-11-02 11:37 PDT, Ilya Tikhonovsky 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Ilya Tikhonovsky
Comment 1 2010-11-02 11:04:47 PDT
Created attachment 72700 [details] [patch] initial version.
Pavel Feldman
Comment 2 2010-11-02 11:16:02 PDT
Comment on attachment 72700 [details] [patch] initial version. You should remove m_domContentEventTime and m_loadEventTime fields as well.
Ilya Tikhonovsky
Comment 3 2010-11-02 11:37:09 PDT
Created attachment 72706 [details] [patch] second iteration
WebKit Commit Bot
Comment 4 2010-11-02 17:07:50 PDT
Comment on attachment 72706 [details] [patch] second iteration Rejecting patch 72706 from commit-queue. Failed to run "['./WebKitTools/Scripts/webkit-patch', '--status-host=queues.webkit.org', 'build', '--no-clean', '--no-update', '--build-style=both']" exit_code: 1 ERROR: Working directory has local commits, pass --force-clean to continue. Full output: http://queues.webkit.org/results/5050003
Ilya Tikhonovsky
Comment 5 2010-11-03 09:43:28 PDT
Comment on attachment 72706 [details] [patch] second iteration Committed r71235 M WebCore/ChangeLog M WebCore/inspector/InspectorController.cpp M WebCore/inspector/InspectorController.h r71235 = ae0c22099bdd2445d99c74576c53c36a30cc9d3f (refs/remotes/trunk)
Note You need to log in before you can comment on or make changes to this bug.