Bug 48837

Summary: REGRESSION (r71097): Many http tests failing on Windows
Product: WebKit Reporter: Adam Roben (:aroben) <aroben>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: jennb
Priority: P2 Keywords: InRadar, LayoutTestFailure, PlatformOnly, Regression
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Windows XP   
URL: http://build.webkit.org/results/Windows%20Release%20(Tests)/r71097%20(5872)/results.html
Attachments:
Description Flags
Only track resource identifiers in DRT when dumpResourceLoadCallbacks is on andersca: review+

Adam Roben (:aroben)
Reported 2010-11-02 08:23:07 PDT
r71097 [1] changed DRT to record resource identifiers even when dumpResourceLoadCallbacks is turned off. This made Windows diverge from the expected test results by including URLs for the main resource. 1. http://trac.webkit.org/changeset/71097
Attachments
Only track resource identifiers in DRT when dumpResourceLoadCallbacks is on (3.95 KB, patch)
2010-11-02 08:28 PDT, Adam Roben (:aroben) 		andersca: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Adam Roben (:aroben)
Comment 1 2010-11-02 08:25:16 PDT
<rdar://problem/8620351>
Adam Roben (:aroben)
Comment 2 2010-11-02 08:28:20 PDT
Created attachment 72670 [details] Only track resource identifiers in DRT when dumpResourceLoadCallbacks is on
Anders Carlsson
Comment 3 2010-11-02 08:29:24 PDT
Comment on attachment 72670 [details] Only track resource identifiers in DRT when dumpResourceLoadCallbacks is on View in context: https://bugs.webkit.org/attachment.cgi?id=72670&action=review > WebKitTools/ChangeLog:59 > + This seems unrelated?
Adam Roben (:aroben)
Comment 4 2010-11-02 08:29:51 PDT
Comment on attachment 72670 [details] Only track resource identifiers in DRT when dumpResourceLoadCallbacks is on View in context: https://bugs.webkit.org/attachment.cgi?id=72670&action=review >> WebKitTools/ChangeLog:59 >> + > > This seems unrelated? Yes, whoops!
Adam Roben (:aroben)
Comment 5 2010-11-02 08:38:21 PDT
Committed r71116: <http://trac.webkit.org/changeset/71116>
Note You need to log in before you can comment on or make changes to this bug.