Bug 48827

Summary:

Web Inspector: make properties and event listeners look consistent with the styles section.

Product:

WebKit

Reporter:

Pavel Feldman <pfeldman>

Component:

Web Inspector (Deprecated)

Assignee:

Pavel Feldman <pfeldman>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

apavlov, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, yurys

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
[IMAGE] Screenshot 1	none
[IMAGE] Screenshot 2	none
[IMAGE] Present looks (1)	none
[IMAGE] Present looks (2)	none
[IMAGE] Present looks (1)	none
[IMAGE] Present looks (2)	none
[PATCH] Patch that makes it look like on screenshots.	timothy: review+

Pavel Feldman

Reported 2010-11-02 04:41:16 PDT

I always wanted to remove this layered section/subsection/etc thingy with too many versions of gradient / grey. Here is what I now have (see screenshots). I know this remove the nice arrow in the listeners section, but as I've heard it was anyways confusing.

Attachments
[IMAGE] Screenshot 1 (99.71 KB, image/png) 2010-11-02 04:41 PDT, Pavel Feldman	no flags	Details
[IMAGE] Screenshot 2 (181.47 KB, image/png) 2010-11-02 04:42 PDT, Pavel Feldman	no flags	Details
[IMAGE] Present looks (1) (147.27 KB, image/png) 2010-11-02 04:47 PDT, Pavel Feldman	no flags	Details
[IMAGE] Present looks (2) (199.84 KB, image/png) 2010-11-02 04:47 PDT, Pavel Feldman	no flags	Details
[IMAGE] Present looks (1) (128.12 KB, image/png) 2010-11-02 04:50 PDT, Pavel Feldman	no flags	Details
[IMAGE] Present looks (2) (182.63 KB, image/png) 2010-11-02 04:50 PDT, Pavel Feldman	no flags	Details
[PATCH] Patch that makes it look like on screenshots. (8.92 KB, patch) 2010-11-02 04:53 PDT, Pavel Feldman	timothy: review+	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Pavel Feldman

Comment 1 2010-11-02 04:41:46 PDT

Created attachment 72645 [details] [IMAGE] Screenshot 1

Pavel Feldman

Comment 2 2010-11-02 04:42:02 PDT

Created attachment 72646 [details] [IMAGE] Screenshot 2

Pavel Feldman

Comment 3 2010-11-02 04:47:34 PDT

Created attachment 72648 [details] [IMAGE] Present looks (1)

Pavel Feldman

Comment 4 2010-11-02 04:47:53 PDT

Created attachment 72649 [details] [IMAGE] Present looks (2)

Pavel Feldman

Comment 5 2010-11-02 04:50:32 PDT

Created attachment 72650 [details] [IMAGE] Present looks (1)

Pavel Feldman

Comment 6 2010-11-02 04:50:54 PDT

Created attachment 72651 [details] [IMAGE] Present looks (2)

Pavel Feldman

Comment 7 2010-11-02 04:53:15 PDT

Created attachment 72652 [details] [PATCH] Patch that makes it look like on screenshots.

Timothy Hatcher

Comment 8 2010-11-02 11:17:54 PDT

Comment on attachment 72652 [details] [PATCH] Patch that makes it look like on screenshots. View in context: https://bugs.webkit.org/attachment.cgi?id=72652&action=review > WebCore/inspector/front-end/PropertiesSection.js:-33 > - I like these empty lines, it makes the constructor calls stand out.

Pavel Feldman

Comment 9 2010-11-02 11:32:05 PDT

Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebCore/ChangeLog M WebCore/inspector/front-end/EventListenersSidebarPane.js M WebCore/inspector/front-end/PropertiesSidebarPane.js M WebCore/inspector/front-end/inspector.css M WebKit/chromium/ChangeLog M WebKit/chromium/src/js/devTools.css Committed r71139

Note You need to log in before you can comment on or make changes to this bug.