Bug 48825

Summary:

Web Inspector: Console messages about starting and finishing profiling are inconsistent

Product:

WebKit

Reporter:

Mikhail Naganov <mnaganov>

Component:

Web Inspector (Deprecated)

Assignee:

Mikhail Naganov <mnaganov>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

apavlov, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, yurys

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Screenshot of the console	none
Proposed fix	pfeldman: review+, mnaganov: commit-queue-

Mikhail Naganov

Reported 2010-11-02 03:02:39 PDT

Created attachment 72643 [details] Screenshot of the console Below are contents of the console: > console.profile("aaa") Profile "aaa " started. > console.profileEnd("aaa") Profile "aaa" finished. > console.profile("aaa") Profile "aaa Run 1 " started. > console.profileEnd("aaa") Profile "aaa Run 2" finished. Should be: > console.profile("aaa") Profile "aaa" started. // <-- no trailing space > console.profileEnd("aaa") Profile "aaa" finished. > console.profile("aaa") Profile "aaa Run 2" started. // <-- must be "Run 2". > console.profileEnd("aaa") Profile "aaa Run 2" finished.

Attachments
Screenshot of the console (17.66 KB, image/png) 2010-11-02 03:02 PDT, Mikhail Naganov	no flags	Details
Proposed fix (2.55 KB, patch) 2010-11-02 08:07 PDT, Mikhail Naganov	pfeldman: review+ mnaganov: commit-queue-	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Mikhail Naganov

Comment 1 2010-11-02 08:07:05 PDT

Created attachment 72666 [details] Proposed fix

Mikhail Naganov

Comment 2 2010-11-03 09:14:31 PDT

Manually committed http://trac.webkit.org/changeset/71242 2010-11-02 Mikhail Naganov <mnaganov@chromium.org> Reviewed by Pavel Feldman. Web Inspector: Fix console messages about starting and finishing profiling. https://bugs.webkit.org/show_bug.cgi?id=48825 * inspector/InspectorProfilerAgent.cpp: (WebCore::InspectorProfilerAgent::addStartProfilingMessageToConsole): * inspector/front-end/ProfilesPanel.js: (WebInspector.ProfilesPanel.prototype.displayTitleForProfileLink):

Note You need to log in before you can comment on or make changes to this bug.