Bug 48817 – Chromium: Propagate a document value changed notification on scroll.

• Component: Accessibility
• Status: RESOLVED FIXED

[Chris Guillory]

To support basic hit testing in Chromium we need to know the top document's scroll offsets. Non-top document scroll offsets are currently lower priority.

[Chris Guillory]

Created attachment 72620 [details]
Send document value changed on scrollbar value changed notification.

[WebKit Review Bot]

Attachment 72620 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
WebCore/accessibility/chromium/AXObjectCacheChromium.cpp:52:  Missing space before ( in if(  [whitespace/parens] [5]
Total errors found: 1 in 8 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Chris Guillory]

Created attachment 72621 [details]
Proposed patch.

Fixed webkit style. Minor updates.

[chris fleizach]

Comment on attachment 72621 [details]
Proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=72621&action=review

looks ok otherwise.

> WebCore/accessibility/chromium/AXObjectCacheChromium.cpp:52
> +    if (obj->roleValue() == ScrollBarRole && notification == AXValueChanged) {

i don't think obj->roleValue() is a strong enough check for doing a static_cast. If not already, I can see something like <div role="scrollbar"> in the future.

You should add a method to AccessibilityScrollbar that says "isNativeScrollbar()" or something to that effect, that will allow you to safely cast.

[Chris Guillory]

Created attachment 72704 [details]
Added isAccessibilityScrollbar to use before casting

[chris fleizach]

Comment on attachment 72704 [details]
Added isAccessibilityScrollbar to use before casting

r=me

[WebKit Commit Bot]

The commit-queue encountered the following flaky tests while processing attachment 72704 [details]:

media/event-attributes.html
fast/workers/storage/use-same-database-in-page-and-workers.html

Please file bugs against the tests.  These tests were authored by [e-mail] and [e-mail].  The commit-queue is continuing to process your patch.

[WebKit Commit Bot]

Comment on attachment 72704 [details]
Added isAccessibilityScrollbar to use before casting

Clearing flags on attachment: 72704

Committed r71198: <http://trac.webkit.org/changeset/71198>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[WebKit Commit Bot]

The commit-queue encountered the following flaky tests while processing attachment 72704 [details]:

fast/workers/storage/use-same-database-in-page-and-workers.html

Please file bugs against the tests.  These tests were authored by [e-mail].  The commit-queue is continuing to process your patch.