Summary: | Set frame name before appending it to the frame tree in the Apple Windows, GTK, and EFL ports | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Daniel Bates <dbates> | ||||
Component: | WebKit Misc. | Assignee: | Daniel Bates <dbates> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | abarth, aroben, leandro, mrobinson | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | PC | ||||||
OS: | Windows XP | ||||||
Bug Depends on: | |||||||
Bug Blocks: | 6751 | ||||||
Attachments: |
|
Description
Daniel Bates
2010-11-01 16:50:45 PDT
Created attachment 72599 [details] Patch At this time we cannot test this change since the observable change is being masked by code in HTMLFrameElementBase::setName() <http://trac.webkit.org/browser/trunk/WebCore/html/HTMLFrameElementBase.cpp?rev=70976#L160> (see comment 1 for more details). Comment on attachment 72599 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=72599&action=review After discussing this with Daniel yesterday, I can confirm that this patch makes a lot of sense. > WebKit/efl/ChangeLog:10 > + Mac, Qt, and Haiku ports. In particular, the set the name of the new I think "the set the name" should probably be "set the name." Committed r71120: <http://trac.webkit.org/changeset/71120> |