Bug 48802

Summary: [chromium] Compile TestNetscapePlugin on chromium win
Product: WebKit Reporter: Tony Chang <tony>
Component: New BugsAssignee: Tony Chang <tony>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, eric, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch tkent: review+

Tony Chang
Reported 2010-11-01 16:28:33 PDT
[chromium] Compile TestNetscapePlugin on chromium win
Attachments
Patch (7.49 KB, patch)
2010-11-01 16:31 PDT, Tony Chang 		tkent: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Tony Chang
Comment 1 2010-11-01 16:31:55 PDT
Created attachment 72594 [details] Patch
Kent Tamura
Comment 2 2010-11-01 16:36:14 PDT
Comment on attachment 72594 [details] Patch looks good.
Tony Chang
Comment 3 2010-11-01 17:01:08 PDT
Committed r71077: <http://trac.webkit.org/changeset/71077>
WebKit Review Bot
Comment 4 2010-11-01 18:00:09 PDT
http://trac.webkit.org/changeset/71077 might have broken GTK Linux 64-bit Debug The following tests are not passing: http/tests/websocket/tests/alert-in-event-handler.html http/tests/websocket/tests/bad-handshake-crash.html http/tests/websocket/tests/bufferedAmount-after-close.html http/tests/websocket/tests/close-on-navigate-new-location.html http/tests/websocket/tests/close-on-unload-and-force-gc.html http/tests/websocket/tests/close-on-unload-reference-in-parent.html http/tests/websocket/tests/close-on-unload.html http/tests/websocket/tests/cross-origin.html http/tests/websocket/tests/error-detect.html http/tests/websocket/tests/frame-length-longer-than-buffer.html http/tests/websocket/tests/frame-length-overflow.html http/tests/websocket/tests/frame-length-skip.html http/tests/websocket/tests/frame-lengths.html http/tests/websocket/tests/handshake-challenge-randomness.html http/tests/websocket/tests/handshake-error.html http/tests/websocket/tests/handshake-fail-by-cross-origin.html http/tests/websocket/tests/handshake-fail-by-no-cr.html http/tests/websocket/tests/handshake-fail-by-sub-protocol-mismatch.html http/tests/websocket/tests/httponly-cookie.pl http/tests/websocket/tests/long-invalid-header.html
Note You need to log in before you can comment on or make changes to this bug.