Bug 48794

Summary: new-run-webkit-tests doesn't strip "LayoutTests/" from prefix, unlike old-run-webkit-tests
Product: WebKit Reporter: Benjamin (Ben) Kalman <kalman>
Component: New BugsAssignee: Benjamin (Ben) Kalman <kalman>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, noel.gordon, ojan
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch
none
Patch none

Description Benjamin (Ben) Kalman 2010-11-01 15:56:02 PDT 
new-run-webkit-tests doesn't strip "LayoutTests/" from prefix, unlike old-run-webkit-tests
Comment 1 Benjamin (Ben) Kalman 2010-11-01 15:57:42 PDT 
Created attachment 72579 [details]
Patch
Comment 2 Ojan Vafai 2010-11-01 16:11:29 PDT 
Comment on attachment 72579 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=72579&action=review

> WebKitTools/Scripts/webkitpy/layout_tests/run_webkit_tests.py:293
> +        test_dir = 'LayoutTests/'

As discussed in person, lets make this a constant and use os.sep.
Comment 3 Benjamin (Ben) Kalman 2010-11-01 16:15:59 PDT 
Created attachment 72587 [details]
Patch
Comment 4 WebKit Commit Bot 2010-11-02 13:41:53 PDT 
The commit-queue encountered the following flaky tests while processing attachment 72587 [details]:

webarchive/test-link-rel-icon.html

Please file bugs against the tests.  These tests were authored by ddkilzer@webkit.org.  The commit-queue is continuing to process your patch.
Comment 5 WebKit Commit Bot 2010-11-02 13:42:58 PDT 
Comment on attachment 72587 [details]
Patch

Clearing flags on attachment: 72587

Committed r71160: <http://trac.webkit.org/changeset/71160>
Comment 6 WebKit Commit Bot 2010-11-02 13:43:02 PDT 
All reviewed patches have been landed.  Closing bug.