Summary: | Setting attr repeatDur=0 on SVG element causes hang | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Matthew Delaney <mdelaney7> | ||||||
Component: | SVG | Assignee: | Matthew Delaney <mdelaney7> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | abarth, bdakin, eric, mdelaney7, webkit.review.bot, zimmermann | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Mac | ||||||||
OS: | OS X 10.6 | ||||||||
URL: | http://www.w3.org/1999/07/30/WD-SVG-19990730/animate.html | ||||||||
Attachments: |
|
Description
Matthew Delaney
2010-11-01 14:36:55 PDT
Created attachment 72563 [details]
Patch
Comment on attachment 72563 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=72563&action=review > WebCore/svg/animation/SVGSMILElement.cpp:531 > - return m_cachedRepeatDur = clockValue < 0 ? SMILTime::unresolved() : clockValue; > + return m_cachedRepeatDur = clockValue <= 0 ? SMILTime::unresolved() : clockValue; The assignment in the return statement is pretty grody here. Please change to: m_cachedRepeatDur = clockValue <= 0 ? SMILTime::unresolved() : clockValue; return m_cachedRepeatDur; > LayoutTests/svg/animations/repeatDur-zero.xhtml:10 > +</svg> > \ No newline at end of file Please add the newline. Created attachment 72570 [details]
Patch
Committed r71066: <http://trac.webkit.org/changeset/71066> http://trac.webkit.org/changeset/71066 might have broken GTK Linux 64-bit Debug The following tests are not passing: accessibility/aria-activedescendant-crash.html accessibility/aria-checkbox-text.html accessibility/aria-hidden-update.html accessibility/contenteditable-hidden-div.html accessibility/crash-with-noelement-selectbox.html accessibility/crashing-a-tag-in-map.html accessibility/document-attributes.html accessibility/first-letter-text-transform-causes-crash.html accessibility/hang-in-isignored.html accessibility/nested-layout-crash.html accessibility/nochildren-elements.html accessibility/non-data-table-cell-title-ui-element.html accessibility/non-native-image-crash.html accessibility/radio-button-checkbox-size.html accessibility/removed-anonymous-block-child-causes-crash.html accessibility/removed-continuation-element-causes-crash.html accessibility/table-modification-crash.html accessibility/table-nofirstbody.html accessibility/table-notbody.html accessibility/table-with-empty-thead-causes-crash.html Matthew, can you change the testcase to include if (window.layoutTestController) layoutTestController.dumpAsText() there's no need to dump render tree information there. At the moment the expected.png/checksum files are missing, but it's useless to add them anyway. When doing that, you might also want to remove the existing expected.txt files from platform/mac/svg/animations, and from the gtk/qt/win/chromium* platform directories (in case they have already landed their own results), and move the expected.txt file right into svg/animations/ Thanks in advance! |