Both the WebProcessConnection and PluginProcessConnection should have NPRemoteObjectMaps

• Component: New Bugs
• Status: RESOLVED FIXED

[Anders Carlsson]

Both the WebProcessConnection and PluginProcessConnection should have NPRemoteObjectMaps

[Anders Carlsson]

Created attachment 72545 [details]
Patch

[Adam Roben (:aroben)]

Comment on attachment 72545 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=72545&action=review

> WebKit2/Shared/Plugins/NPRemoteObjectMap.cpp:57
> +uint64_t NPRemoteObjectMap::registerNPObject(NPObject* npObject)
> +{
> +    uint64_t npObjectID = generateNPObjectID();
> +
> +    OwnPtr<NPObjectMessageReceiver> npObjectMessageReceiver = NPObjectMessageReceiver::create(npObject);
> +    m_registeredNPObjects.set(npObjectID, npObjectMessageReceiver.leakPtr());

I'm not sure the local variable really helps here.

It doesn't seem like this function will do the right thing if the same npObject is passed in twice.

> WebKit2/Shared/Plugins/NPRemoteObjectMap.h:33
> +#include <wtf/HashMap.h>
>  #include <wtf/Noncopyable.h>
> +#include <WebCore/npruntime.h>

ASCII order please!

> WebKit2/Shared/Plugins/NPRemoteObjectMap.h:42
> +class NPObjectProxy;
> +class NPObjectMessageReceiver;

Here too!

> WebKit2/Shared/Plugins/NPRemoteObjectMap.h:53
> +    // Creates an NPObjectProxy wrapper for the remote object with the given remote object ID.
> +    NPObjectProxy* getOrCreateNPObjectProxy(uint64_t remoteObjectID);
> +
> +    uint64_t registerNPObject(NPObject*);

No comment here? This function seems at least as mysterious as getOrCreateNPObjectProxy.

[Eric Seidel (no email)]

Curious what the status is here?  I assume this was landed?

[Anders Carlsson]

Committed r71051: <http://trac.webkit.org/changeset/71051>