Bug 48736

Summary: [Qt] Short-circuit QWebPage::selectedText() if frame has no selection
Product: WebKit Reporter: Andreas Kling <kling>
Component: WebKit QtAssignee: QtWebKit Unassigned <webkit-qt-unassigned>
Status: RESOLVED FIXED    
Severity: Normal Keywords: Performance, Qt, QtTriaged
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Proposed patch none

Andreas Kling
Reported 2010-10-31 12:49:15 PDT
As mentioned on bug 48722, QWebPage::selectedText() could do an early return if the frame's selection is empty.
Attachments
Proposed patch (1.32 KB, patch)
2010-10-31 12:51 PDT, Andreas Kling 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Andreas Kling
Comment 1 2010-10-31 12:51:58 PDT
Created attachment 72471 [details] Proposed patch
Andreas Kling
Comment 2 2010-10-31 13:42:34 PDT
Comment on attachment 72471 [details] Proposed patch Clearing flags on attachment: 72471 Committed r70999: <http://trac.webkit.org/changeset/70999>
Andreas Kling
Comment 3 2010-10-31 13:42:43 PDT
All reviewed patches have been landed. Closing bug.
Antonio Gomes
Comment 4 2010-10-31 19:43:30 PDT
Comment on attachment 72471 [details] Proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=72471&action=review > WebKit/qt/Api/qwebpage.cpp:2422 > + if (frame->selection()->selection().selectionType() == VisibleSelection::NoSelection) This is a bad internal API =/ : 5 "selection"s for this single simple statement, being on of them "selection()->selection()" Nice shortcut though!
Note You need to log in before you can comment on or make changes to this bug.