Summary: | Percentage z offset in transform-origin should make the property invalid | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Simon Fraser (smfr) <simon.fraser> | ||||||
Component: | CSS | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | cmarrin, rwlbuis, simon.fraser | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | All | ||||||||
OS: | OS X 10.5 | ||||||||
Attachments: |
|
Description
Simon Fraser (smfr)
2010-10-29 18:11:39 PDT
Created attachment 74497 [details]
Patch
Comment on attachment 74497 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=74497&action=review > LayoutTests/fast/css/script-tests/transform-origin-parsing.js:18 > +shouldBe('test("-webkit-transform-origin: 10px 10px 10px", "-webkit-transform-origin")', '"10px 10px 10px"'); It might be good to also test a lack of units on the z value: "-webkit-transform-origin: 10px 10px 10" This should not parse. Hi Simon, (In reply to comment #2) > (From update of attachment 74497 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=74497&action=review > > > LayoutTests/fast/css/script-tests/transform-origin-parsing.js:18 > > +shouldBe('test("-webkit-transform-origin: 10px 10px 10px", "-webkit-transform-origin")', '"10px 10px 10px"'); > > It might be good to also test a lack of units on the z value: > "-webkit-transform-origin: 10px 10px 10" > This should not parse. I added it locally and unfortunately it does parse. It is due to the m_strict usage in parseTransformOriginShorthand, should I force it to true? Or is that something for another patch/bug? Cheers, Rob. Created attachment 74724 [details]
I noticed that unfortunately my previous patch caused regressions, sorry about that! This one causes no regressions but ofcourse needs to rechecked. Cheers, Rob
(In reply to comment #3) > I added it locally and unfortunately it does parse. It is due to the m_strict usage in > parseTransformOriginShorthand, should I force it to true? Or is that something for > another patch/bug? Hm, maybe that is expected to work. Let's leave that for another patch (if indeed it needs fixing). |