Bug 4870

Summary: win portability: fix IS_NEGATIVE_ZERO macro in simple_number.h
Product: WebKit Reporter: Krzysztof Kowalczyk <kkowalczyk>
Component: JavaScriptCoreAssignee: Maciej Stachowiak <mjs>
Status: VERIFIED FIXED    
Severity: Normal    
Priority: P2    
Version: 420+   
Hardware: PC   
OS: Windows XP   
Attachments:
Description Flags
fix IS_NEGATIVE_ZERO macro on win darin: review+

Krzysztof Kowalczyk
Reported 2005-09-06 19:53:59 PDT
#define IS_NEGATIVE_ZERO(num) (_fpclass(num) == _FPCLASS_NZ) is much better test for negative zero on windows than #define IS_NEGATIVE_ZERO(num) (num == 0.0 && !memcmp(&num, &SimpleNumber::negZero, sizeof(double))) This reduces number of jsc tests failed on win from 86 to 75.
Attachments
fix IS_NEGATIVE_ZERO macro on win (647 bytes, patch)
2005-09-06 19:54 PDT, Krzysztof Kowalczyk 		darin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Krzysztof Kowalczyk
Comment 1 2005-09-06 19:54:38 PDT
Created attachment 3790 [details] fix IS_NEGATIVE_ZERO macro on win
Darin Adler
Comment 2 2005-09-06 22:42:20 PDT
Comment on attachment 3790 [details] fix IS_NEGATIVE_ZERO macro on win r=me
Note You need to log in before you can comment on or make changes to this bug.