Bug 48693 – Add idl and mock classes for FileWriterSync.

• Component: DOM
• Status: RESOLVED FIXED

[Eric U.]

The implementation will follow soon after.

[Eric U.]

Created attachment 72423 [details]
Patch

[David Levin]

Comment on attachment 72423 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=72423&action=review

> WebCore/ChangeLog:19
> +        * bindings/scripts/CodeGeneratorV8.pm:

And android's build file?

So many build files....

> WebCore/fileapi/FileWriterSync.h:54
> +    void write(Blob* data, ExceptionCode& ec);

No need for param name "ec".

> WebCore/fileapi/FileWriterSync.h:55
> +    void seek(long long position, ExceptionCode& ec);

Ditto.

> WebCore/fileapi/FileWriterSync.h:56
> +    void truncate(long long length, ExceptionCode& ec);

Ditto.

> WebCore/fileapi/FileWriterSync.h:73
> +    friend class WTF::RefCounted<FileWriterSync>;

I believe that WTF:: is unnecessary.

[Eric U.]

(In reply to comment #2)
> (From update of attachment 72423 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=72423&action=review
> 
> > WebCore/ChangeLog:19
> > +        * bindings/scripts/CodeGeneratorV8.pm:
> 
> And android's build file?

It looks like Android doesn't have any support for FILE_SYSTEM classes in any of its build files yet.  How about I open a separate bug for that?

> So many build files....

Sigh.  Oh, for a meta-build system.

> > WebCore/fileapi/FileWriterSync.h:54
> > +    void write(Blob* data, ExceptionCode& ec);
> 
> No need for param name "ec".

Fixed.

> > WebCore/fileapi/FileWriterSync.h:55
> > +    void seek(long long position, ExceptionCode& ec);
> 
> Ditto.
> 
> > WebCore/fileapi/FileWriterSync.h:56
> > +    void truncate(long long length, ExceptionCode& ec);
> 
> Ditto.
> 
> > WebCore/fileapi/FileWriterSync.h:73
> > +    friend class WTF::RefCounted<FileWriterSync>;
> 
> I believe that WTF:: is unnecessary.

Fixed.

[Eric U.]

(In reply to comment #3)
> (In reply to comment #2)
> > (From update of attachment 72423 [details] [details])
> > View in context: https://bugs.webkit.org/attachment.cgi?id=72423&action=review
> > 
> > > WebCore/ChangeLog:19
> > > +        * bindings/scripts/CodeGeneratorV8.pm:
> > 
> > And android's build file?
> 
> It looks like Android doesn't have any support for FILE_SYSTEM classes in any of its build files yet.  How about I open a separate bug for that?
> 
> > So many build files....
> 
> Sigh.  Oh, for a meta-build system.
> 
> > > WebCore/fileapi/FileWriterSync.h:54
> > > +    void write(Blob* data, ExceptionCode& ec);
> > 
> > No need for param name "ec".
> 
> Fixed.
> 
> > > WebCore/fileapi/FileWriterSync.h:55
> > > +    void seek(long long position, ExceptionCode& ec);
> > 
> > Ditto.
> > 
> > > WebCore/fileapi/FileWriterSync.h:56
> > > +    void truncate(long long length, ExceptionCode& ec);
> > 
> > Ditto.
> > 
> > > WebCore/fileapi/FileWriterSync.h:73
> > > +    friend class WTF::RefCounted<FileWriterSync>;
> > 
> > I believe that WTF:: is unnecessary.
> 
> Fixed.

[will hopefully upload shortly; I'm having some build issues right now]

[Eric U.]

Created attachment 73325 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 73325 [details]
Patch

Clearing flags on attachment: 73325

Committed r71711: <http://trac.webkit.org/changeset/71711>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[WebKit Review Bot]

http://trac.webkit.org/changeset/71711 might have broken Chromium Win Release