|Summary:||Disable media/video-canvas-alpha.html layout test for Qt & GTK|
|Product:||WebKit||Reporter:||Aaron Colwell <acolwell>|
|Component:||New Bugs||Assignee:||Nobody <webkit-unassigned>|
|Severity:||Normal||CC:||kling, mrobinson, pnormand|
|Version:||528+ (Nightly build)|
|OS:||OS X 10.5|
Description Aaron Colwell 2010-10-29 15:18:16 PDT
Disable layout test for platforms that don't support video
Comment 2 Andreas Kling 2010-10-29 16:47:27 PDT
Committed r70952: <http://trac.webkit.org/changeset/70952>
Comment 3 Martin Robinson 2010-10-29 22:34:23 PDT
GTK+ supports video through Gstreamer and runs many of the media tests. Was this skip the result of a failure or was it preemptive?
Comment 4 Aaron Colwell 2010-10-30 10:14:06 PDT
(In reply to comment #3) > GTK+ supports video through Gstreamer and runs many of the media tests. Was this skip the result of a failure or was it preemptive? Check out the comments towards the bottom of https://bugs.webkit.org/show_bug.cgi?id=48094 Personally I didn't see where my new layout test broke the GTK build. I only saw positive confirmation on the Qt build. I was told to disable the tests for both Qt & GTK. I'm a newbie to this project so I just relied on what I was being told to do. Feel free to reenable it for the GTK build.
Comment 5 Martin Robinson 2010-10-30 10:28:13 PDT
No problem, I was just curious. In general it's useful to has as much information about the failure as possible. If it's a bug with your patch or test, you'll probably be interested in fixing it. If it's a bug on Qt and GTK+ more information is useful for triaging it and getting the test unskipped.
Comment 6 Philippe Normand 2010-11-02 03:02:42 PDT
The test runs fine on GTK+ which, as Martin points out, supports HTML5 media since a while now. :) I will unskip the test and keep an eye on the buildbot.