Bug 48688

Summary: Disable media/video-canvas-alpha.html layout test for Qt & GTK
Product: WebKit Reporter: Aaron Colwell <acolwell>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: kling, mrobinson, pnormand
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
Proposed Patch levin: review+, levin: commit-queue+

Aaron Colwell
Reported 2010-10-29 15:18:16 PDT
Disable layout test for platforms that don't support video
Attachments
Proposed Patch (1.45 KB, patch)
2010-10-29 15:20 PDT, Aaron Colwell 		levin: review+
levin: commit-queue+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Aaron Colwell
Comment 1 2010-10-29 15:20:46 PDT
Created attachment 72404 [details] Proposed Patch
Andreas Kling
Comment 2 2010-10-29 16:47:27 PDT
Committed r70952: <http://trac.webkit.org/changeset/70952>
Martin Robinson
Comment 3 2010-10-29 22:34:23 PDT
GTK+ supports video through Gstreamer and runs many of the media tests. Was this skip the result of a failure or was it preemptive?
Aaron Colwell
Comment 4 2010-10-30 10:14:06 PDT
(In reply to comment #3) > GTK+ supports video through Gstreamer and runs many of the media tests. Was this skip the result of a failure or was it preemptive? Check out the comments towards the bottom of https://bugs.webkit.org/show_bug.cgi?id=48094 Personally I didn't see where my new layout test broke the GTK build. I only saw positive confirmation on the Qt build. I was told to disable the tests for both Qt & GTK. I'm a newbie to this project so I just relied on what I was being told to do. Feel free to reenable it for the GTK build.
Martin Robinson
Comment 5 2010-10-30 10:28:13 PDT
No problem, I was just curious. In general it's useful to has as much information about the failure as possible. If it's a bug with your patch or test, you'll probably be interested in fixing it. If it's a bug on Qt and GTK+ more information is useful for triaging it and getting the test unskipped.
Philippe Normand
Comment 6 2010-11-02 03:02:42 PDT
The test runs fine on GTK+ which, as Martin points out, supports HTML5 media since a while now. :) I will unskip the test and keep an eye on the buildbot.
Note You need to log in before you can comment on or make changes to this bug.