| Summary: | Disable media/video-canvas-alpha.html layout test for Qt & GTK | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Aaron Colwell <acolwell> | ||||
| Component: | New Bugs | Assignee: | Nobody <webkit-unassigned> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | kling, mrobinson, pnormand | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | PC | ||||||
| OS: | OS X 10.5 | ||||||
| Attachments: |
|
||||||
|
Description
Aaron Colwell
2010-10-29 15:18:16 PDT
Created attachment 72404 [details]
Proposed Patch
Committed r70952: <http://trac.webkit.org/changeset/70952> GTK+ supports video through Gstreamer and runs many of the media tests. Was this skip the result of a failure or was it preemptive? (In reply to comment #3) > GTK+ supports video through Gstreamer and runs many of the media tests. Was this skip the result of a failure or was it preemptive? Check out the comments towards the bottom of https://bugs.webkit.org/show_bug.cgi?id=48094 Personally I didn't see where my new layout test broke the GTK build. I only saw positive confirmation on the Qt build. I was told to disable the tests for both Qt & GTK. I'm a newbie to this project so I just relied on what I was being told to do. Feel free to reenable it for the GTK build. No problem, I was just curious. In general it's useful to has as much information about the failure as possible. If it's a bug with your patch or test, you'll probably be interested in fixing it. If it's a bug on Qt and GTK+ more information is useful for triaging it and getting the test unskipped. The test runs fine on GTK+ which, as Martin points out, supports HTML5 media since a while now. :) I will unskip the test and keep an eye on the buildbot. |