Summary: | ASSERTION FAILURE in WebProcessProxy::frameDestroyed when a Page is closed before it can send the DidCreateMainFrame message to the UIProcess | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Jessie Berlin <jberlin> | ||||
Component: | WebKit2 | Assignee: | Jessie Berlin <jberlin> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | andersca, jberlin, sam | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | All | ||||||
OS: | All | ||||||
Attachments: |
|
Description
Jessie Berlin
2010-10-29 12:05:26 PDT
Created attachment 72366 [details]
Remove the invalid assertion
Comment on attachment 72366 [details] Remove the invalid assertion View in context: https://bugs.webkit.org/attachment.cgi?id=72366&action=review > WebKit2/UIProcess/WebProcessProxy.cpp:492 > + return; You can remove the call to m_frameMap.contains here, m_frameMap.remove will work just fine even if the frame doesn't exist in the map and it will avoid an extra hash lookup. (In reply to comment #2) > (From update of attachment 72366 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=72366&action=review > > > WebKit2/UIProcess/WebProcessProxy.cpp:492 > > + return; > > You can remove the call to m_frameMap.contains here, m_frameMap.remove will work just fine even if the frame doesn't exist in the map and it will avoid an extra hash lookup. Done. Comment on attachment 72366 [details] Remove the invalid assertion Commited in r70915 http://trac.webkit.org/changeset/70915 |