Bug 4864

Summary: Remove unnecessary KRenderingPaintServer creation
Product: WebKit Reporter: Tobias Lidskog <tobiaslidskog>
Component: SVGAssignee: Eric Seidel (no email) <eric>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P4    
Version: 420+   
Hardware: Mac   
OS: OS X 10.4   
Attachments:
Description Flags
patch to KCanvasRenderingStyle + test cases
none
fix mime type, this is a .gz file eric: review+

Tobias Lidskog
Reported 2005-09-06 02:27:32 PDT
Currently KRenderingPaintServers are sometimes created even when there shouldn't be any fill/stroke. In the tree dump this can be seen as [stroke={}] and [fill={}]. Creating paint servers for strokes also has the side effect that bounding box calculation is effected. The problem lays in KCanvasRenderingStyle::updateFill/Stroke.
Attachments
patch to KCanvasRenderingStyle + test cases (151.48 KB, text/plain)
2005-09-06 02:30 PDT, Tobias Lidskog 		no flags
Details
fix mime type, this is a .gz file (151.48 KB, application/octet-stream)
2005-09-06 02:32 PDT, Tobias Lidskog 		eric: review+
Details
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Tobias Lidskog
Comment 1 2005-09-06 02:30:38 PDT
Created attachment 3780 [details] patch to KCanvasRenderingStyle + test cases Calling strokePainter()/fillPainter() will create a painter if none exists. Don't do this if there shouldn't be any fill/stroke
Tobias Lidskog
Comment 2 2005-09-06 02:32:02 PDT
Created attachment 3781 [details] fix mime type, this is a .gz file
Eric Seidel (no email)
Comment 3 2005-09-06 03:08:28 PDT
Comment on attachment 3781 [details] fix mime type, this is a .gz file Looks good to me. r=me.
Note You need to log in before you can comment on or make changes to this bug.