Bug 48626

Summary: [Qt] Make GraphicsContext cheaper to construct
Product: WebKit Reporter: Andreas Kling <kling>
Component: Layout and RenderingAssignee: QtWebKit Unassigned <webkit-qt-unassigned>
Status: RESOLVED FIXED    
Severity: Normal Keywords: Performance, Qt, QtTriaged
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Proposed patch kenneth: review+

Andreas Kling
Reported 2010-10-29 05:55:47 PDT
We're currently doing some unnecessary stuff, like creating a black QBrush and throwing it away, and using setRenderHint() instead of setRenderHints().
Attachments
Proposed patch (3.80 KB, patch)
2010-10-29 06:09 PDT, Andreas Kling 		kenneth: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Andreas Kling
Comment 1 2010-10-29 06:09:10 PDT
Created attachment 72320 [details] Proposed patch
Kenneth Rohde Christiansen
Comment 2 2010-10-29 06:17:49 PDT
Comment on attachment 72320 [details] Proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=72320&action=review > WebCore/ChangeLog:10 > + - Don't call setPlatform*(), set the painter brush and pen directly. Maybe add a comment about this in the code so that noone adds setPlatform in the future. > WebCore/platform/graphics/qt/GraphicsContextQt.cpp:238 > + // use the default the QPainter was constructed with Comments start with capital letter and ends with a dot, you should know that by now :-) > WebCore/platform/graphics/qt/GraphicsContextQt.cpp:257 > + // solidColor is initialized with the fillColor() Again! </3
Andreas Kling
Comment 3 2010-10-29 06:45:17 PDT
Committed r70870: <http://trac.webkit.org/changeset/70870>
Note You need to log in before you can comment on or make changes to this bug.