Bug 48609

Summary:

WebEvent.h #includes things it doesn't need

Product:

WebKit

Reporter:

Adam Roben (:aroben) <aroben>

Component:

New Bugs

Assignee:

Adam Roben (:aroben) <aroben>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, andersca, eric, webkit-ews, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Other

OS:

OS X 10.5

Attachments:

Description	Flags
Patch	none
Letting the EWS chew on this	none
Remove unnecessary #includes from WebEvent.h	none
Remove unnecessary #includes from WebEvent.h	none

Adam Roben (:aroben)

Reported 2010-10-28 19:42:48 PDT

WebEvent.h #includes things it doesn't need

Attachments
Patch (13.08 KB, patch) 2010-10-28 19:43 PDT, Adam Roben (:aroben)	no flags	Details Formatted Diff Diff
Letting the EWS chew on this (12.96 KB, patch) 2010-10-29 07:06 PDT, Adam Roben (:aroben)	no flags	Details Formatted Diff Diff
Remove unnecessary #includes from WebEvent.h (13.54 KB, patch) 2010-10-29 08:05 PDT, Adam Roben (:aroben)	no flags	Details Formatted Diff Diff
Remove unnecessary #includes from WebEvent.h (14.05 KB, patch) 2010-10-29 08:39 PDT, Adam Roben (:aroben)	no flags	Details Formatted Diff Diff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

Adam Roben (:aroben)

Comment 1 2010-10-28 19:43:48 PDT

Created attachment 72286 [details] Patch

Adam Roben (:aroben)

Comment 2 2010-10-29 07:06:52 PDT

Created attachment 72330 [details] Letting the EWS chew on this

WebKit Review Bot

Comment 3 2010-10-29 07:10:07 PDT

Attachment 72330 [details] did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1 WebKit2/Shared/WebTouchEvent.cpp:30: Alphabetical sorting problem. [build/include_order] [4] WebKit2/Shared/WebEvent.h:35: Code inside a namespace should not be indented. [whitespace/indent] [4] WebKit2/UIProcess/WebUIClient.h:35: Code inside a namespace should not be indented. [whitespace/indent] [4] WebKit2/Shared/WebPlatformTouchPoint.cpp:30: Alphabetical sorting problem. [build/include_order] [4] WebKit2/Shared/WebMouseEvent.cpp:28: Alphabetical sorting problem. [build/include_order] [4] WebKit2/Shared/WebWheelEvent.cpp:28: Alphabetical sorting problem. [build/include_order] [4] WebKit2/Shared/WebKeyboardEvent.cpp:28: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 7 in 17 files If any of these errors are false positives, please file a bug against check-webkit-style.

Early Warning System Bot

Comment 4 2010-10-29 07:48:07 PDT

Attachment 72330 [details] did not build on qt: Build output: http://queues.webkit.org/results/4858068

Adam Roben (:aroben)

Comment 5 2010-10-29 08:05:47 PDT

Created attachment 72335 [details] Remove unnecessary #includes from WebEvent.h

WebKit Review Bot

Comment 6 2010-10-29 08:07:50 PDT

Attachment 72335 [details] did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1 WebKit2/Shared/WebTouchEvent.cpp:30: Alphabetical sorting problem. [build/include_order] [4] WebKit2/Shared/WebEvent.h:35: Code inside a namespace should not be indented. [whitespace/indent] [4] WebKit2/Shared/qt/WebEventFactoryQt.cpp:32: Alphabetical sorting problem. [build/include_order] [4] WebKit2/UIProcess/WebUIClient.h:35: Code inside a namespace should not be indented. [whitespace/indent] [4] WebKit2/Shared/WebPlatformTouchPoint.cpp:30: Alphabetical sorting problem. [build/include_order] [4] WebKit2/Shared/WebMouseEvent.cpp:28: Alphabetical sorting problem. [build/include_order] [4] WebKit2/Shared/WebWheelEvent.cpp:28: Alphabetical sorting problem. [build/include_order] [4] WebKit2/Shared/WebKeyboardEvent.cpp:28: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 8 in 18 files If any of these errors are false positives, please file a bug against check-webkit-style.

Early Warning System Bot

Comment 7 2010-10-29 08:31:41 PDT

Attachment 72335 [details] did not build on qt: Build output: http://queues.webkit.org/results/4804063

Adam Roben (:aroben)

Comment 8 2010-10-29 08:39:14 PDT

Created attachment 72339 [details] Remove unnecessary #includes from WebEvent.h

WebKit Review Bot

Comment 9 2010-10-29 08:44:25 PDT

Attachment 72339 [details] did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1 WebKit2/Shared/WebTouchEvent.cpp:30: Alphabetical sorting problem. [build/include_order] [4] WebKit2/Shared/WebEvent.h:35: Code inside a namespace should not be indented. [whitespace/indent] [4] WebKit2/Shared/qt/WebEventFactoryQt.cpp:32: Alphabetical sorting problem. [build/include_order] [4] WebKit2/UIProcess/WebUIClient.h:35: Code inside a namespace should not be indented. [whitespace/indent] [4] WebKit2/Shared/WebPlatformTouchPoint.cpp:30: Alphabetical sorting problem. [build/include_order] [4] WebKit2/Shared/WebMouseEvent.cpp:28: Alphabetical sorting problem. [build/include_order] [4] WebKit2/Shared/WebWheelEvent.cpp:28: Alphabetical sorting problem. [build/include_order] [4] WebKit2/Shared/WebKeyboardEvent.cpp:28: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 8 in 19 files If any of these errors are false positives, please file a bug against check-webkit-style.

Adam Roben (:aroben)

Comment 10 2010-10-29 09:28:09 PDT

Committed r70885: <http://trac.webkit.org/changeset/70885>

WebKit Review Bot

Comment 11 2010-10-29 09:59:02 PDT

http://trac.webkit.org/changeset/70885 might have broken GTK Linux 32-bit Release The following tests are not passing: inspector/audits-panel-functional.html

Adam Roben (:aroben)

Comment 12 2010-10-29 16:36:12 PDT

Committed r70885: <http://trac.webkit.org/changeset/70885>

Note You need to log in before you can comment on or make changes to this bug.