| Summary: | WebEvent.h #includes things it doesn't need | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Adam Roben (:aroben) <aroben> | ||||||||||
| Component: | New Bugs | Assignee: | Adam Roben (:aroben) <aroben> | ||||||||||
| Status: | RESOLVED FIXED | ||||||||||||
| Severity: | Normal | CC: | abarth, andersca, eric, webkit-ews, webkit.review.bot | ||||||||||
| Priority: | P2 | ||||||||||||
| Version: | 528+ (Nightly build) | ||||||||||||
| Hardware: | Other | ||||||||||||
| OS: | OS X 10.5 | ||||||||||||
| Attachments: |
|
||||||||||||
|
Description
Adam Roben (:aroben)
2010-10-28 19:42:48 PDT
Created attachment 72286 [details]
Patch
Created attachment 72330 [details]
Letting the EWS chew on this
Attachment 72330 [details] did not pass style-queue:
Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
WebKit2/Shared/WebTouchEvent.cpp:30: Alphabetical sorting problem. [build/include_order] [4]
WebKit2/Shared/WebEvent.h:35: Code inside a namespace should not be indented. [whitespace/indent] [4]
WebKit2/UIProcess/WebUIClient.h:35: Code inside a namespace should not be indented. [whitespace/indent] [4]
WebKit2/Shared/WebPlatformTouchPoint.cpp:30: Alphabetical sorting problem. [build/include_order] [4]
WebKit2/Shared/WebMouseEvent.cpp:28: Alphabetical sorting problem. [build/include_order] [4]
WebKit2/Shared/WebWheelEvent.cpp:28: Alphabetical sorting problem. [build/include_order] [4]
WebKit2/Shared/WebKeyboardEvent.cpp:28: Alphabetical sorting problem. [build/include_order] [4]
Total errors found: 7 in 17 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Attachment 72330 [details] did not build on qt: Build output: http://queues.webkit.org/results/4858068 Created attachment 72335 [details]
Remove unnecessary #includes from WebEvent.h
Attachment 72335 [details] did not pass style-queue:
Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
WebKit2/Shared/WebTouchEvent.cpp:30: Alphabetical sorting problem. [build/include_order] [4]
WebKit2/Shared/WebEvent.h:35: Code inside a namespace should not be indented. [whitespace/indent] [4]
WebKit2/Shared/qt/WebEventFactoryQt.cpp:32: Alphabetical sorting problem. [build/include_order] [4]
WebKit2/UIProcess/WebUIClient.h:35: Code inside a namespace should not be indented. [whitespace/indent] [4]
WebKit2/Shared/WebPlatformTouchPoint.cpp:30: Alphabetical sorting problem. [build/include_order] [4]
WebKit2/Shared/WebMouseEvent.cpp:28: Alphabetical sorting problem. [build/include_order] [4]
WebKit2/Shared/WebWheelEvent.cpp:28: Alphabetical sorting problem. [build/include_order] [4]
WebKit2/Shared/WebKeyboardEvent.cpp:28: Alphabetical sorting problem. [build/include_order] [4]
Total errors found: 8 in 18 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Attachment 72335 [details] did not build on qt: Build output: http://queues.webkit.org/results/4804063 Created attachment 72339 [details]
Remove unnecessary #includes from WebEvent.h
Attachment 72339 [details] did not pass style-queue:
Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
WebKit2/Shared/WebTouchEvent.cpp:30: Alphabetical sorting problem. [build/include_order] [4]
WebKit2/Shared/WebEvent.h:35: Code inside a namespace should not be indented. [whitespace/indent] [4]
WebKit2/Shared/qt/WebEventFactoryQt.cpp:32: Alphabetical sorting problem. [build/include_order] [4]
WebKit2/UIProcess/WebUIClient.h:35: Code inside a namespace should not be indented. [whitespace/indent] [4]
WebKit2/Shared/WebPlatformTouchPoint.cpp:30: Alphabetical sorting problem. [build/include_order] [4]
WebKit2/Shared/WebMouseEvent.cpp:28: Alphabetical sorting problem. [build/include_order] [4]
WebKit2/Shared/WebWheelEvent.cpp:28: Alphabetical sorting problem. [build/include_order] [4]
WebKit2/Shared/WebKeyboardEvent.cpp:28: Alphabetical sorting problem. [build/include_order] [4]
Total errors found: 8 in 19 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Committed r70885: <http://trac.webkit.org/changeset/70885> http://trac.webkit.org/changeset/70885 might have broken GTK Linux 32-bit Release The following tests are not passing: inspector/audits-panel-functional.html Committed r70885: <http://trac.webkit.org/changeset/70885> |