Bug 4856
Summary: | Plain text fields should not have "Make Link" in their contextual menu | ||
---|---|---|---|
Product: | WebKit | Reporter: | mitz |
Component: | Forms | Assignee: | Nobody <webkit-unassigned> |
Status: | RESOLVED FIXED | ||
Severity: | Normal | CC: | bdakin, ian |
Priority: | P3 | ||
Version: | 420+ | ||
Hardware: | Mac | ||
OS: | OS X 10.4 | ||
URL: | http://www.ibm.com/ |
mitz
A "Make Link" item shows up in the contextual menu of a plain text field if the selected text is a URL. The
item does not belong there, since you cannot do make a link in a plain text field.
To reproduce: open attachment 2978 [details] in Safari, select all text in the text field and control-click the
selected text.
Expected: no "Make Link" item in the contextual menu.
Actual: "Make Link" item shows up in the contextual menu.
Attachments | ||
---|---|---|
Add attachment proposed patch, testcase, etc. |
Eric Seidel (no email)
Hum... too bad there is no way to make a layout test for this. I wonder if this is a form control issue or an
editing issue. Probably form controls, in which case this would be in render_forms.cpp I think.
mitz
Woops, the testcase to open is attachment 2987 [details].
I think this is basically an AppKit issue: open Interface Builder and create a window with a text field. Enter
test mode, type an HTTP URI into the text field, select all and control-click.
mitz
In TOT (with Safari 2.0.4) there is no longer a Make Link item but there are two consecutive separators between Go To Address and Copy.