|Summary:||[Qt] refcount assertion on WebPageProxy, when closing a window|
|Severity:||Normal||CC:||christian.webkit, commit-queue, darin, sam|
|Version:||528+ (Nightly build)|
Description zalan 2010-10-28 12:19:09 PDT
Comment 2 Sam Weinig 2010-11-11 16:04:51 PST
Comment on attachment 73586 [details] remove extra adoptref The implementation of createNewPage should return a retained WKPageRef, so the existing code is correct.
Comment 3 Darin Adler 2010-11-11 16:34:02 PST
This is probably a bug in the test program, not WebKit2 itself.
Comment 4 zalan 2010-11-11 23:56:20 PST
ok, thanks for the clarification.
Comment 6 Andreas Kling 2010-11-19 15:00:58 PST
Comment on attachment 74380 [details] retain WKPageRef LGTM
Comment 7 WebKit Commit Bot 2010-11-19 22:26:28 PST
The commit-queue encountered the following flaky tests while processing attachment 74380 [details]: fast/profiler/throw-exception-from-eval.html Please file bugs against the tests. These tests were authored by firstname.lastname@example.org, email@example.com, and firstname.lastname@example.org. The commit-queue is continuing to process your patch.
Comment 8 WebKit Commit Bot 2010-11-19 22:29:23 PST
Comment on attachment 74380 [details] retain WKPageRef Clearing flags on attachment: 74380 Committed r72468: <http://trac.webkit.org/changeset/72468>
Comment 9 WebKit Commit Bot 2010-11-19 22:29:30 PST
All reviewed patches have been landed. Closing bug.