Bug 48547

Summary: [chromium] add a result-small.json file for the test dashboard
Product: WebKit Reporter: Ojan Vafai <ojan>
Component: New BugsAssignee: Ojan Vafai <ojan>
Status: RESOLVED FIXED    
Severity: Normal CC: evan, tony, victorw
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch
none
Patch tony: review+

Description Ojan Vafai 2010-10-28 12:15:49 PDT
[chromium] add a result-small.json file for the test dashboard
Comment 1 Ojan Vafai 2010-10-28 12:18:34 PDT
Created attachment 72218 [details]
Patch
Comment 2 Victor Wang 2010-10-28 12:31:49 PDT
LGTM. Thanks for taking care of this.
Comment 3 Tony Chang 2010-10-28 12:41:01 PDT
Comment on attachment 72218 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=72218&action=review

> WebKitTools/TestResultServer/model/jsonresults.py:444
> +                (master, builder, test_type, JSON_RESULTS_FILE_SMALL))

filename instead of JSON_RESULTS_FILE_SMALL, right?

> WebKitTools/TestResultServer/model/jsonresults_unittest.py:31
> +sys.path.append(sys.path[0] + '/..')

os.path.join, but I think you can just do sys.path.append("..").

> WebKitTools/TestResultServer/model/jsonresults_unittest.py:34
> +sys.path.append('/usr/local/google_appengine/')
> +sys.path.append('/usr/local/google_appengine/lib/yaml/lib/')

tears :(
Comment 4 Ojan Vafai 2010-10-28 14:34:11 PDT
Created attachment 72235 [details]
Patch
Comment 5 Ojan Vafai 2010-10-28 14:34:57 PDT
(In reply to comment #3)
> (From update of attachment 72218 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=72218&action=review
> 
> > WebKitTools/TestResultServer/model/jsonresults.py:444
> > +                (master, builder, test_type, JSON_RESULTS_FILE_SMALL))
> 
> filename instead of JSON_RESULTS_FILE_SMALL, right?

Whoops.

> > WebKitTools/TestResultServer/model/jsonresults_unittest.py:31
> > +sys.path.append(sys.path[0] + '/..')
> > WebKitTools/TestResultServer/model/jsonresults_unittest.py:34
> > +sys.path.append('/usr/local/google_appengine/')
> > +sys.path.append('/usr/local/google_appengine/lib/yaml/lib/')
> 
> tears :(

At Evan's suggestion, I just put in an error message if you're missing one of these.
Comment 6 Ojan Vafai 2010-10-28 16:20:10 PDT
Committed r70822: <http://trac.webkit.org/changeset/70822>