Summary: | [chromium] add a result-small.json file for the test dashboard | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Ojan Vafai <ojan> | ||||||
Component: | New Bugs | Assignee: | Ojan Vafai <ojan> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | evan, tony, victorw | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Other | ||||||||
OS: | OS X 10.5 | ||||||||
Attachments: |
|
Description
Ojan Vafai
2010-10-28 12:15:49 PDT
Created attachment 72218 [details]
Patch
LGTM. Thanks for taking care of this. Comment on attachment 72218 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=72218&action=review > WebKitTools/TestResultServer/model/jsonresults.py:444 > + (master, builder, test_type, JSON_RESULTS_FILE_SMALL)) filename instead of JSON_RESULTS_FILE_SMALL, right? > WebKitTools/TestResultServer/model/jsonresults_unittest.py:31 > +sys.path.append(sys.path[0] + '/..') os.path.join, but I think you can just do sys.path.append(".."). > WebKitTools/TestResultServer/model/jsonresults_unittest.py:34 > +sys.path.append('/usr/local/google_appengine/') > +sys.path.append('/usr/local/google_appengine/lib/yaml/lib/') tears :( Created attachment 72235 [details]
Patch
(In reply to comment #3) > (From update of attachment 72218 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=72218&action=review > > > WebKitTools/TestResultServer/model/jsonresults.py:444 > > + (master, builder, test_type, JSON_RESULTS_FILE_SMALL)) > > filename instead of JSON_RESULTS_FILE_SMALL, right? Whoops. > > WebKitTools/TestResultServer/model/jsonresults_unittest.py:31 > > +sys.path.append(sys.path[0] + '/..') > > WebKitTools/TestResultServer/model/jsonresults_unittest.py:34 > > +sys.path.append('/usr/local/google_appengine/') > > +sys.path.append('/usr/local/google_appengine/lib/yaml/lib/') > > tears :( At Evan's suggestion, I just put in an error message if you're missing one of these. Committed r70822: <http://trac.webkit.org/changeset/70822> |