Summary: | Home/End, PgUp, PgDwn, spacebar, shift+spacebar, etc. should respect writing-mode | ||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Dave Hyatt <hyatt> | ||||||||||||
Component: | Layout and Rendering | Assignee: | Dave Hyatt <hyatt> | ||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||
Severity: | Normal | CC: | abarth, eric, mitz, webkit.review.bot | ||||||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||||
Hardware: | Mac | ||||||||||||||
OS: | OS X 10.5 | ||||||||||||||
Bug Depends on: | |||||||||||||||
Bug Blocks: | 46123 | ||||||||||||||
Attachments: |
|
Description
Dave Hyatt
2010-10-28 11:56:27 PDT
Created attachment 76101 [details]
Part 1: Patch for Mac WebKit 1 views.
Created attachment 76110 [details]
Part 1: Patch for Mac WebKit 1 views.
Comment on attachment 76110 [details] Part 1: Patch for Mac WebKit 1 views. View in context: https://bugs.webkit.org/attachment.cgi?id=76110&action=review > WebKit/mac/WebView/WebFrameView.mm:595 > + if (isVertical) { > + if (!isFlipped) > + NSMakePoint(frame.origin.x, NSMaxY(frame)); > + else > + NSMakePoint(frame.origin.x, NSMinY(frame)); > + } else { > + if (!isFlipped) > + NSMakePoint(NSMaxX(frame), frame.origin.y); > + else > + NSMakePoint(NSMinX(frame), frame.origin.y); > + } I think you meant to assign the result of NSMakePoint() to point (In reply to comment #4) > (From update of attachment 76110 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=76110&action=review > > > WebKit/mac/WebView/WebFrameView.mm:595 > > + if (isVertical) { > > + if (!isFlipped) > > + NSMakePoint(frame.origin.x, NSMaxY(frame)); > > + else > > + NSMakePoint(frame.origin.x, NSMinY(frame)); > > + } else { > > + if (!isFlipped) > > + NSMakePoint(NSMaxX(frame), frame.origin.y); > > + else > > + NSMakePoint(NSMinX(frame), frame.origin.y); > > + } > > I think you meant to assign the result of NSMakePoint() to point WORST PATCH EVER! Created attachment 76115 [details]
Part 1: Patch for Mac WebKit 1 views.
Comment on attachment 76115 [details] Part 1: Patch for Mac WebKit 1 views. View in context: https://bugs.webkit.org/attachment.cgi?id=76115&action=review > WebKit/mac/WebView/WebFrameView.mm:604 > + greenspace Comment on attachment 76115 [details] Part 1: Patch for Mac WebKit 1 views. View in context: https://bugs.webkit.org/attachment.cgi?id=76115&action=review > WebKit/mac/WebView/WebFrameView.mm:544 > + return renderView->style()->isHorizontalWritingMode(); Sense here seems backwards! Created attachment 76418 [details]
Part 2: Patch for WebKit2 views.
Comment on attachment 76418 [details] Part 2: Patch for WebKit2 views. View in context: https://bugs.webkit.org/attachment.cgi?id=76418&action=review > WebKit2/WebProcess/WebPage/mac/WebPageMac.mm:112 > +static inline void logicalScroll(Page* page, ScrollLogicalDirection direction, ScrollGranularity granularity) > +{ > + page->focusController()->focusedOrMainFrame()->eventHandler()->logicalScrollRecursively(direction, granularity); > +} Is anyone still calling the scroll() function above? Can we remove it? Fixed in r73941. Created attachment 76420 [details]
Cleanup on Windows.
Comment on attachment 76420 [details]
Cleanup on Windows.
Is it possible to add a test for this?
http://trac.webkit.org/changeset/73941 might have broken SnowLeopard Intel Release (Tests) and GTK Linux 64-bit Debug The following tests are not passing: editing/selection/extend-to-line-boundary.html |