Bug 48540 – Support the text-orientation CSS property

• Component: Layout and Rendering
• Status: RESOLVED FIXED

[Dave Hyatt]

Support the text-orientation CSS property (both back end and front end support).

[Dave Hyatt]

Created attachment 84810 [details]
Not really for review yet. Testing builds.

[Dave Hyatt]

Created attachment 84958 [details]
Not for review yet.

[WebKit Review Bot]

Attachment 84958 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/WebCore.exp.in', u'Source/W..." exit_code: 1

Source/WebCore/rendering/InlineFlowBox.cpp:328:  Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side.  [whitespace/operators] [4]
Source/WebCore/platform/graphics/cocoa/FontPlatformData.h:132:  Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side.  [whitespace/operators] [4]
Total errors found: 2 in 29 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Build Bot]

Attachment 84958 [details] did not build on win:
Build output: http://queues.webkit.org/results/8105524

[Dave Hyatt]

Created attachment 84970 [details]
Not for review yet.

[WebKit Review Bot]

Attachment 84970 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/WebCore.exp.in', u'Source/W..." exit_code: 1

Source/WebCore/rendering/InlineFlowBox.cpp:328:  Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side.  [whitespace/operators] [4]
Source/WebCore/platform/graphics/cocoa/FontPlatformData.h:132:  Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side.  [whitespace/operators] [4]
Source/WebCore/platform/graphics/win/FontCustomPlatformDataCairo.cpp:35:  Missing space after ,  [whitespace/comma] [3]
Total errors found: 3 in 44 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Early Warning System Bot]

Attachment 84958 [details] did not build on qt:
Build output: http://queues.webkit.org/results/8105530

[WebKit Review Bot]

Attachment 84958 [details] did not build on chromium:
Build output: http://queues.webkit.org/results/8098827

[WebKit Review Bot]

Attachment 84958 [details] did not build on chromium:
Build output: http://queues.webkit.org/results/8103613

[Dave Hyatt]

Created attachment 85073 [details]
Patch for review

[WebKit Review Bot]

Attachment 85073 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/fast..." exit_code: 1

Source/WebCore/rendering/InlineFlowBox.cpp:328:  Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side.  [whitespace/operators] [4]
Source/WebCore/platform/graphics/cocoa/FontPlatformData.h:132:  Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side.  [whitespace/operators] [4]
Source/WebCore/platform/graphics/FontFastPath.cpp:86:  Should only a single space after a punctuation in a comment.  [whitespace/comments] [5]
Source/WebCore/platform/graphics/FontFastPath.cpp:125:  Should only a single space after a punctuation in a comment.  [whitespace/comments] [5]
Source/WebCore/platform/graphics/win/FontCustomPlatformDataCairo.cpp:35:  Missing space after ,  [whitespace/comma] [3]
Source/WebCore/platform/graphics/SimpleFontData.h:155:  The parameter name "orientation" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 6 in 49 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment on attachment 85073 [details]
Patch for review

View in context: https://bugs.webkit.org/attachment.cgi?id=85073&action=review

> Source/WebCore/WebCore.xcodeproj/project.pbxproj:-5800
> -		FD3160A112B026F700C1A359 /* HRTFPanner.h in Headers */ = {isa = PBXBuildFile; fileRef = FD31606B12B026F700C1A359 /* HRTFPanner.h */; };

Did you remove this header from the project? Why?

> Source/WebCore/WebCore.xcodeproj/project.pbxproj:-20814
> -				FD3160A112B026F700C1A359 /* HRTFPanner.h in Headers */,

Ditto.

> Source/WebCore/css/CSSValueKeywords.in:796
> +vertical-right
> +upright

Can we keep these in alphabetical order?

[Dave Hyatt]

Created attachment 85079 [details]
Patch for review

[WebKit Review Bot]

Attachment 85079 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/fast..." exit_code: 1

Source/WebCore/platform/graphics/win/FontCustomPlatformDataCairo.cpp:35:  Missing space after ,  [whitespace/comma] [3]
Total errors found: 1 in 49 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Dave Hyatt]

Fixed in r80582.

[Ryosuke Niwa]

Leopard build fix in http://trac.webkit.org/changeset/80608.

[Ryosuke Niwa]

I tried to fix Chromium Linux in http://trac.webkit.org/changeset/80610 but we're still geting some build errors as of r80610 (http://build.webkit.org/builders/Chromium%20Linux%20Release/builds/24806/steps/compile-webkit/logs/stdio):

Source/WebCore/platform/graphics/chromium/SimpleFontDataLinux.cpp: In member function ‘void WebCore::SimpleFontData::platformInit()’:
Source/WebCore/platform/graphics/chromium/SimpleFontDataLinux.cpp:122: error: ‘m_orientation’ was not declared in this scope
make: *** [out/Release/obj.target/webcore_platform/Source/WebCore/platform/graphics/chromium/SimpleFontDataLinux.o] Error 1

Could either one of you let us know what's the correct fix here?  Or land a build fix ASAP?

[WebKit Review Bot]

http://trac.webkit.org/changeset/80582 might have broken SnowLeopard Intel Release (Tests) and GTK Linux 32-bit Release