| Summary: | Work around a Mac driver bug in generateMipmap | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Zhenyao Mo <zmo> | ||||
| Component: | WebGL | Assignee: | Zhenyao Mo <zmo> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | cmarrin, enne, kbr, mrowe | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | PC | ||||||
| OS: | OS X 10.5 | ||||||
| Bug Depends on: | |||||||
| Bug Blocks: | 48528 | ||||||
| Attachments: |
|
||||||
|
Description
Zhenyao Mo
2010-10-27 17:59:44 PDT
Created attachment 72124 [details]
patch
Tested, Worlds of WebGL demo works with this patch in Chromium.
Comment on attachment 72124 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=72124&action=review Excellent work tracking this down. There is one error in the ChangeLog though. Please fix before committing. > WebCore/ChangeLog:9 > + (WebCore::WebGLRenderingContext::generateMipmap): Make sure minFilter is set to LINEAR_MIPMAP_LINEAR before generateMipmap, and after the call, set it back to the original value. This should be NEAREST_MIPMAP_LINEAR. Can you please add a reference in the code to the bug report about the driver issue? Without one it’s going to be more difficult to determine whether the underlying issue has been addressed. (In reply to comment #3) > Can you please add a reference in the code to the bug report about the driver issue? Without one it’s going to be more difficult to determine whether the underlying issue has been addressed. OK, I created a bug for adding reference to bug reports. https://bugs.webkit.org/show_bug.cgi?id=48528 I want to land this now. I am working on a test case for the bug report. Committed r70784: <http://trac.webkit.org/changeset/70784> |