Bug 48435

Summary: REGRESSION (r70655): Many plugins tests are failing on Qt
Product: WebKit Reporter: Adam Roben (:aroben) <aroben>
Component: New BugsAssignee: Adam Roben (:aroben) <aroben>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, eric, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch andersca: review+

Description Adam Roben (:aroben) 2010-10-27 10:06:50 PDT
REGRESSION (r70655): Many plugins tests are failing on Qt
Comment 1 Adam Roben (:aroben) 2010-10-27 10:07:31 PDT
Created attachment 72050 [details]
Patch
Comment 2 WebKit Review Bot 2010-10-27 10:12:50 PDT
Attachment 72050 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
WebKitTools/DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:53:  PluginTest::NPP_Destroy is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
WebKitTools/DumpRenderTree/TestNetscapePlugIn/Tests/NullNPPGetValuePointer.cpp:58:  NullNPPGetValuePointer::NPP_Destroy is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Total errors found: 2 in 6 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Adam Roben (:aroben) 2010-10-27 10:14:07 PDT
Committed r70662: <http://trac.webkit.org/changeset/70662>
Comment 4 WebKit Review Bot 2010-10-27 14:04:03 PDT
http://trac.webkit.org/changeset/70662 might have broken GTK Linux 32-bit Debug