Bug 48426

Summary: Add runtime flag check before enabling speech input in code.
Product: WebKit Reporter: Satish Sampath <satish>
Component: FormsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, steveblock
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 39485    
Attachments:
Description Flags
Patch none

Description Satish Sampath 2010-10-27 06:43:03 PDT 
In https://bugs.webkit.org/show_bug.cgi?id=43146 I added a runtime flag for speech input and used that in the IDL where speech input attributes were declared. At that time I believed that was sufficient and no additions were necessary in the code. However I now find that only covers the V8/JSC bindings and not the inline attribute declarations in HTML. Hence this patch to add the runtime flag check in code.
Comment 1 Satish Sampath 2010-10-27 06:48:02 PDT 
Created attachment 72028 [details]
Patch
Comment 2 Steve Block 2010-10-27 07:59:39 PDT 
Comment on attachment 72028 [details]
Patch

r=me
Comment 3 Steve Block 2010-10-27 08:00:26 PDT 
Comment on attachment 72028 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=72028&action=review

> WebCore/ChangeLog:6
> +        https://bugs.webkit.org/show_bug.cgi?id=48426

Should add a comment about how this is tested.
Comment 4 WebKit Commit Bot 2010-10-27 08:16:58 PDT 
Comment on attachment 72028 [details]
Patch

Clearing flags on attachment: 72028

Committed r70644: <http://trac.webkit.org/changeset/70644>
Comment 5 WebKit Commit Bot 2010-10-27 08:17:03 PDT 
All reviewed patches have been landed.  Closing bug.