Bug 48419

Summary: [WINCE] Buildfix after r70400.
Product: WebKit Reporter: Patrick R. Gansterer <paroga>
Component: PlatformAssignee: Patrick R. Gansterer <paroga>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, ossy, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: Other   
Attachments:
Description Flags
Patch none

Description Patrick R. Gansterer 2010-10-27 05:20:14 PDT
see patch
Comment 1 Patrick R. Gansterer 2010-10-27 05:22:51 PDT
Created attachment 72017 [details]
Patch
Comment 2 WebKit Review Bot 2010-10-27 05:26:54 PDT
Attachment 72017 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
WebCore/platform/wince/TemporaryLinkStubs.cpp:27:  Found other header before a header this file implements. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Csaba Osztrogon√°c 2010-10-27 07:20:30 PDT
Comment on attachment 72017 [details]
Patch

r=me
Comment 4 WebKit Commit Bot 2010-10-27 08:03:25 PDT
Comment on attachment 72017 [details]
Patch

Rejecting patch 72017 from commit-queue.

Failed to run "['./WebKitTools/Scripts/webkit-patch', '--status-host=queues.webkit.org', 'build-and-test', '--no-clean', '--no-update', '--test', '--non-interactive']" exit_code: 2
Last 500 characters of output:
tNull ......
java/lc3/ConvertNumber ...........
java/lc3/ConvertString .......
java/lc3/ConvertUndefined ...
java/lc3/Exceptions .
java/lc3/JSBoolean ........
java/lc3/JSNull .....
java/lc3/JSNumber ...................................
java/lc3/JSObject .............
java/lc3/JSObject/ToObject-001.html -> failed

Exiting early after 1 failures. 17647 tests run.
294.99s total testing time

17646 test cases (99%) succeeded
1 test case (<1%) had incorrect layout
5 test cases (<1%) had stderr output

Full output: http://queues.webkit.org/results/4766027
Comment 5 Patrick R. Gansterer 2010-10-27 08:05:54 PDT
Comment on attachment 72017 [details]
Patch

Try again!
Comment 6 WebKit Commit Bot 2010-10-27 08:30:34 PDT
Comment on attachment 72017 [details]
Patch

Clearing flags on attachment: 72017

Committed r70646: <http://trac.webkit.org/changeset/70646>
Comment 7 WebKit Commit Bot 2010-10-27 08:30:39 PDT
All reviewed patches have been landed.  Closing bug.