Bug 48411
Summary: | Spellcheck should be done/removed when HTMLElement.spellcheck property is changed | ||
---|---|---|---|
Product: | WebKit | Reporter: | Hajime Morrita <morrita> |
Component: | HTML Editing | Assignee: | Nobody <webkit-unassigned> |
Status: | NEW | ||
Severity: | Normal | CC: | ddavidso, eric, jiapu.mail, mcrha, shinyak |
Priority: | P2 | ||
Version: | 528+ (Nightly build) | ||
Hardware: | PC | ||
OS: | All | ||
See Also: | https://bugs.webkit.org/show_bug.cgi?id=236937 | ||
Bug Depends on: | 25536 | ||
Bug Blocks: |
Hajime Morrita
- When spellcheck property is set to true, spellchecking against that node should be done and wrong word should be marked immediately.
- When spellcheck property is set to false, markers should be removed.
On "true" side, The solution would be similar to 40092.
Attachments | ||
---|---|---|
Add attachment proposed patch, testcase, etc. |
Milan Crha
(Make it clickable: bug #40092)
This is still applicable in WebKit2 (webkit2gtk3-2.20.2).
Ideally, if the <body>'s spellcheck property is changed to true (even without delay, no async here please, thus application can set it to false and immediately back to true), the words in the current viewport are refreshed and when the user scrolls the new words in the viewport are updated too. It'll be good for performance, especially with very large (more than 500KB) documents.
Additionally, when using webkit_web_context_set_spell_checking_enabled(), the 'false' works as expected, but setting it back to 'true' doesn't update spell check markers of the current viewport.