Summary: | WebKit2 shouldn't try to send an empty user agent | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Brian Weinstein <bweinstein> | ||||||
Component: | WebKit2 | Assignee: | Brian Weinstein <bweinstein> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | abarth, eric, sam, webkit.review.bot | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | PC | ||||||||
OS: | OS X 10.5 | ||||||||
Attachments: |
|
Description
Brian Weinstein
2010-10-26 21:45:22 PDT
Created attachment 71981 [details]
[PATCH] Fix
(In reply to comment #1) > Created an attachment (id=71981) [details] > [PATCH] Fix Will send out a new patch with a better explanation and a test. Created attachment 71986 [details]
[PATCH] Fix with test
Attachment 71986 [details] did not pass style-queue:
Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
WebKitTools/TestWebKitAPI/Tests/WebKit2/PreventEmptyUserAgent.cpp:26: Found other header before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4]
WebKitTools/TestWebKitAPI/Tests/WebKit2/PreventEmptyUserAgent.cpp:28: Alphabetical sorting problem. [build/include_order] [4]
Total errors found: 2 in 6 files
If any of these errors are false positives, please file a bug against check-webkit-style.
http://trac.webkit.org/changeset/70658 might have broken GTK Linux 32-bit Debug http://trac.webkit.org/changeset/70659 might have broken GTK Linux 32-bit Debug |