Bug 48366

Summary:

pageDidScroll callback should be on the UI process client rather than (or in addition to) the web process client

Product:

WebKit

Reporter:

Anders Carlsson <andersca>

Component:

New Bugs

Assignee:

Anders Carlsson <andersca>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

sam, webkit-ews, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Other

OS:

OS X 10.5

Attachments:

Description	Flags
Patch	sam: review+

Description Anders Carlsson 2010-10-26 12:41:00 PDT

pageDidScroll callback should be on the UI process client rather than (or in addition to) the web process client

Comment 1 Anders Carlsson 2010-10-26 12:43:50 PDT

Created attachment 71928 [details]
Patch

Comment 2 WebKit Review Bot 2010-10-26 12:51:47 PDT

Attachment 71928 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
WebKit2/UIProcess/API/C/WKPage.h:165:  Extra space between WKPageDidDrawCallback and didDraw  [whitespace/declaration] [3]
WebKit2/UIProcess/API/C/WKPage.h:166:  Extra space between WKPageDidScrollCallback and pageDidScroll  [whitespace/declaration] [3]
WebKitTools/WebKitTestRunner/TestController.cpp:125:  One space before end of line comments  [whitespace/comments] [5]
WebKitTools/WebKitTestRunner/TestController.cpp:211:  One space before end of line comments  [whitespace/comments] [5]
Total errors found: 4 in 11 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 3 Early Warning System Bot 2010-10-26 12:57:54 PDT

Attachment 71928 [details] did not build on qt:
Build output: http://queues.webkit.org/results/4851012

Comment 4 Sam Weinig 2010-10-26 12:58:33 PDT

But fix Qt.

Comment 5 Anders Carlsson 2010-10-26 13:29:08 PDT

Committed r70564: <http://trac.webkit.org/changeset/70564>