Bug 48366

Summary: pageDidScroll callback should be on the UI process client rather than (or in addition to) the web process client
Product: WebKit Reporter: Anders Carlsson <andersca>
Component: New BugsAssignee: Anders Carlsson <andersca>
Status: RESOLVED FIXED    
Severity: Normal CC: sam, webkit-ews, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch sam: review+

Anders Carlsson
Reported 2010-10-26 12:41:00 PDT
pageDidScroll callback should be on the UI process client rather than (or in addition to) the web process client
Attachments
Patch (8.55 KB, patch)
2010-10-26 12:43 PDT, Anders Carlsson 		sam: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Anders Carlsson
Comment 1 2010-10-26 12:43:50 PDT
Created attachment 71928 [details] Patch
WebKit Review Bot
Comment 2 2010-10-26 12:51:47 PDT
Attachment 71928 [details] did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1 WebKit2/UIProcess/API/C/WKPage.h:165: Extra space between WKPageDidDrawCallback and didDraw [whitespace/declaration] [3] WebKit2/UIProcess/API/C/WKPage.h:166: Extra space between WKPageDidScrollCallback and pageDidScroll [whitespace/declaration] [3] WebKitTools/WebKitTestRunner/TestController.cpp:125: One space before end of line comments [whitespace/comments] [5] WebKitTools/WebKitTestRunner/TestController.cpp:211: One space before end of line comments [whitespace/comments] [5] Total errors found: 4 in 11 files If any of these errors are false positives, please file a bug against check-webkit-style.
Early Warning System Bot
Comment 3 2010-10-26 12:57:54 PDT
Attachment 71928 [details] did not build on qt: Build output: http://queues.webkit.org/results/4851012
Sam Weinig
Comment 4 2010-10-26 12:58:33 PDT
But fix Qt.
Anders Carlsson
Comment 5 2010-10-26 13:29:08 PDT
Committed r70564: <http://trac.webkit.org/changeset/70564>
Note You need to log in before you can comment on or make changes to this bug.