Bug 48363

Summary:

Chromium: Update resource tracking when moving a frame between documents

Product:

WebKit

Reporter:

Jenn Braithwaite <jennb>

Component:

Page Loading

Assignee:

Jenn Braithwaite <jennb>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, commit-queue, dimich, fishd

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

OS X 10.5

Bug Depends on:

44713

Bug Blocks:

Attachments:

Description	Flags
patch	none
updated patch to remove unnecessary frame parameter	none
updated patch - use map.contains()	none

Jenn Braithwaite

Reported 2010-10-26 12:33:14 PDT

Chromium fix for bug reported in 44713. That patch provides the framework for the fix and fixes the Mac platform. Separate patches will be submitted for other platforms, thus this separate bug.

Attachments
patch (6.88 KB, patch) 2010-10-27 17:46 PDT, Jenn Braithwaite	no flags	Details Formatted Diff Diff
updated patch to remove unnecessary frame parameter (6.38 KB, patch) 2010-10-28 16:55 PDT, Jenn Braithwaite	no flags	Details Formatted Diff Diff
updated patch - use map.contains() (6.32 KB, patch) 2010-11-01 11:25 PDT, Jenn Braithwaite	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Jenn Braithwaite

Comment 1 2010-10-27 17:46:50 PDT

Created attachment 72121 [details] patch

Dmitry Titov

Comment 2 2010-10-28 16:09:48 PDT

Comment on attachment 72121 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=72121&action=review > WebKit/chromium/src/FrameLoaderClientImpl.cpp:1394 > + oldWebFrame->client()->removeIdentifierForRequest(oldWebFrame, identifier); It looks like we are passing here wrong webFrame... Do we really need this parameter?

Jenn Braithwaite

Comment 3 2010-10-28 16:55:46 PDT

Created attachment 72261 [details] updated patch to remove unnecessary frame parameter

Adam Barth

Comment 4 2010-10-31 18:08:36 PDT

Needs fishd for WebKit API review.

Jenn Braithwaite

Comment 5 2010-11-01 11:25:46 PDT

Created attachment 72526 [details] updated patch - use map.contains()

Darin Fisher (:fishd, Google)

Comment 6 2010-11-01 13:21:25 PDT

Comment on attachment 72526 [details] updated patch - use map.contains() API change looks good to me. Is it possible to write a layout test for this?

Jenn Braithwaite

Comment 7 2010-11-01 13:26:47 PDT

(In reply to comment #6) > (From update of attachment 72526 [details]) > API change looks good to me. Is it possible to write a layout test for this? The layout test is in the patch submitted with bug 44713. Both that test (fast/frames/iframe-reparenting-fail-load.html) and fast/frames/iframe-reparenting-adopt-node.html cover this change.

Dmitry Titov

Comment 8 2010-11-03 11:55:15 PDT

Comment on attachment 72526 [details] updated patch - use map.contains() r=me

WebKit Commit Bot

Comment 9 2010-11-03 19:13:38 PDT

Comment on attachment 72526 [details] updated patch - use map.contains() Clearing flags on attachment: 72526 Committed r71297: <http://trac.webkit.org/changeset/71297>

WebKit Commit Bot

Comment 10 2010-11-03 19:13:43 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.