Bug 48335 – [GTK] [review] Support for new-window in GtkLauncher

• Component: WebKitGTK
• Status: RESOLVED FIXED

[Nicolas Dufresne]

Created attachment 71894 [details]
Enable popup window in GtkLauncher

The GtkLauncher application does not support opening new window when a "target=_blank" is clicked or similar call to window.open() is made withing a user gesture. Instead, GtkLauncher does nothing. This prevents using GtkLauncher for testing certain sites. The attach patch implement minimal support for creating new window. This is done by implementing signals "create-web-view", "web-view-ready" and "close-web-view".

[Martin Robinson]

Comment on attachment 71894 [details]
Enable popup window in GtkLauncher

Great patch. I'm in favor of putting a little more into GtkLauncher while keeping it minimal. This patch does need a ChangeLog though, which can be generated via prepare-ChangeLog in the WebKitTools/Scripts directory.

[Martin Robinson]

CCing some other GTK+ reviewers, who might have more insight into whether this should be added to GtkLauncher. I'm all for it though.

[Xan Lopez]

Yes. I'm also in favor of keeping the launcher (very) minimal, but this seems to be needed to browse to some pages since we do nothing in the default handler of create-web-view. Perhaps that's something we should fix too, not sure.

[Martin Robinson]

(In reply to comment #3)
> Yes. I'm also in favor of keeping the launcher (very) minimal, but this seems to be needed to browse to some pages since we do nothing in the default handler of create-web-view. Perhaps that's something we should fix too, not sure.

I think two good metrics to help decide whether or not to put something in the GTKLauncher are:

1. Will this help debug layout test failures?
2. Will this help demonstrate the API to embedders?

In my mind, this patch does both.

[Nicolas Dufresne]

Created attachment 72336 [details]
Enable popup window in GtkLauncher (with changelog)

The GtkLauncher application does not support opening new window when
a link with "target=_blank" is clicked or similar call to
window.open(). Instead, GtkLauncher does nothing which breaks
navigation of some websites.

[Martin Robinson]

Comment on attachment 72336 [details]
Enable popup window in GtkLauncher (with changelog)

View in context: https://bugs.webkit.org/attachment.cgi?id=72336&action=review

> WebKitTools/ChangeLog:11
> +        Enable popup window in GtkLauncher
> +
> +        The GtkLauncher application does not support opening new window when
> +        a link with "target=_blank" is clicked or similar call to
> +        window.open(). Instead, GtkLauncher does nothing which breaks
> +        navigation of some websites.
> +        https://bugs.webkit.org/show_bug.cgi?id=48335

It's more typical for the order to be:
<bug title>
<bug url>

<description>

This isn't a big deal though, and I'll fix it locally before landing.

[Xan Lopez]

(In reply to comment #6)
> It's more typical for the order to be:
> <bug title>
> <bug url>
> 
> <description>
> 
> This isn't a big deal though, and I'll fix it locally before landing.

prepare-ChangeLog --bug <number> gets it right for you at no extra cost! :)

[Martin Robinson]

Committed r70886: <http://trac.webkit.org/changeset/70886>